Fixes #6109
Remove unused code from wallet and validation interface #6152
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:remove_unused_cwallet changing 4 files +0 −19-
fanquake commented at 9:13 AM on May 18, 2015: member
-
08d9373e2f
Remove unused code from wallet and validation interface
Fixes #6109
- laanwj added the label Wallet on May 18, 2015
-
jonasschnelli commented at 1:36 PM on May 18, 2015: contributor
code-review ACK. I think we don't need that code part (
EraseTransaction) in near future. Removing makes sense. -
laanwj commented at 10:51 AM on May 21, 2015: member
Not convinced about this. I do think we want to be able to remove unconfirmed, or conflicting transactions at some point (e.g. when implementing replace-by-fee, or other cases where the transaction is to time out after a while if it doesn't make it into a block). ("hide" semantics would work too, of course, instead of truly deleting, but there needs to be a notification path for this)
-
luke-jr commented at 3:58 AM on June 2, 2015: member
@laanwj I don't see a case where deleting or hiding a still-valid transaction is a good idea. And the only way it can become invalid is if a conflicting one is confirmed; even in that case, I don't think we want erase semantics. IMO the signal should go. The wallet may conceivably want to erase a transaction it is respending itself, especially once the respend has confirmed, so I agree the CWallet method should stay for now.
-
- laanwj merged this on Jun 5, 2015
- laanwj closed this on Jun 5, 2015
- laanwj referenced this in commit 12cdbabc26 on Jun 5, 2015
- fanquake deleted the branch on May 12, 2016
- zkbot referenced this in commit df07f9ad23 on Feb 15, 2017
- MarcoFalke locked this on Sep 8, 2021
Contributors
Labels