build: disable optional use of gmp in internal secp256k1 build #6210

1. 
   laanwj commented at 9:18 am on June 1, 2015: member

   Until secp256k1 is used for verification there is no reason for Bitcoin Core’s secp256k1 to link against gmp, even if available. Pass a flag to configure to override the bignum implementation.

   This fixes a crash at runtime on ppc64 reported by @gmaxwell.

   Edit: tested and appears to work, after autogen and reconfigure, src/secp256k1/config.log contains

   0configure:13140: Using bignum implementation: no
   

   … whereas it was using gmp before.

2. build: disable optional use of gmp in internal secp256k1 build

   Until secp256k1 is used for verification there is no reason for Bitcoin
   Core's secp256k1 to link against gmp, even if available. Pass a flag to
   configure to override the bignum implementation.
   
   This fixes a crash at runtime on ppc64 reported by @gmaxwell.

   7fd5b801ff
3. laanwj added the label Build system on Jun 1, 2015
4. 
   laanwj commented at 9:19 am on June 1, 2015: member

   Needs to go into 0.11 branch as well
5. 
   luke-jr commented at 9:35 am on June 1, 2015: member

   Nit: –without-bignum would be slightly nicer IMO
6. 
   laanwj commented at 9:44 am on June 1, 2015: member

   @luke-jr No opinion on that, but I’m just following secp256k1’s configure --help
7. laanwj merged this on Jun 2, 2015
8. laanwj closed this on Jun 2, 2015

   ---

9. laanwj referenced this in commit 0e4f2a0a1f on Jun 2, 2015
10. laanwj referenced this in commit dfdb6dd052 on Jun 2, 2015
11. 
    theuni commented at 1:45 pm on June 2, 2015: member

    post-merge ack.
12. MarcoFalke locked this on Sep 8, 2021

Contributors
laanwj luke-jr theuni

Labels
Build system