[OSX] revert renaming of Bitcoin-Qt.app and use CFBundleDisplayName (partial revert of #6116) #6214

jonasschnelli commented at 1:50 PM on June 1, 2015: contributor

Reverts the renaming of the app bundle, uses "Bitcoin Core" as CFBundleDisplayName and keeps "Bitcoin-Core" as disk image name and title.

[OSX] revert renaming of Bitcoin-Qt.app a2241eabfd

Diapolo commented at 1:53 PM on June 1, 2015: none

Were there problems with the new name?

jonasschnelli commented at 1:54 PM on June 1, 2015: contributor

@Diapolo: see #6212

laanwj commented at 2:15 PM on June 1, 2015: member

@diapolo the problem seems to be that there is no upgrade path for applications that change name. People will end up with two versions installed, which can be problematic.It's kind of unfortunate.

laanwj commented at 6:13 AM on June 2, 2015: member

@jonasschnelli had any luck with the CFBundleDisplayName?

jonasschnelli commented at 6:32 AM on June 2, 2015: contributor

Start working on it in about 4h.

jonasschnelli commented at 11:18 AM on June 2, 2015: contributor

Found a solution to keep the application bundle name "Bitcoin-Qt.app" while using "Bitcoin Core" as display name. I'm now forming a proper commit and test it over gitian.

laanwj commented at 11:53 AM on June 2, 2015: member

Very nice!

jonasschnelli commented at 11:57 AM on June 2, 2015: contributor

Credits goes to @theuni for sketching this approach. Thanks.

theuni commented at 1:53 PM on June 2, 2015: member

Glad this actually worked!

What's the reason for not just adding Base.lproj/InfoPlist.strings in git, though? Looks like we were faking it before with Resources/empty.lproj, but now that we actually have something to put in there, may as well just commit the files and copy them into the bundle during creation.

jonasschnelli commented at 2:09 PM on June 2, 2015: contributor

The nice thing with faking the file during the make process is that we not add another file containing a static string for the application name. But I agree it's a bit of a hack.

There is also a problem with .DS_Store (positioning) I'd like to fix. I think this PR is ready by tmr.

jonasschnelli force-pushed on Jun 2, 2015

jonasschnelli renamed this:
~~[OSX] revert renaming of Bitcoin-Qt.app (partial revert of #6116)~~
[OSX] revert renaming of Bitcoin-Qt.app and use CFBundleDisplayName (partial revert of #6116)
on Jun 2, 2015

jonasschnelli force-pushed on Jun 2, 2015

jonasschnelli force-pushed on Jun 3, 2015

jonasschnelli commented at 7:42 AM on June 3, 2015: contributor

This is PR final now Test dmg: https://builds.jonasschnelli.ch/pulls/6214/

Application name shows "Bitcoin Core" but the application bundles name is still "Bitcoin-Qt.app". If you drag "Bitcoin Core" to your /Applications dir, it will ask you if you like to overwrite "Bitcoin-Qt.app".

Prove screens: OSX10.10 bildschirmfoto 2015-06-03 um 09 38 51

OSX10.7 bildschirmfoto 2015-06-03 um 09 39 54

fanquake commented at 8:03 AM on June 3, 2015: member

@theuni @jonasschnelli awesome work, will test shortly.

OSX: use "Bitcoin Core" as Bundle Display Name 0a32a9347e

jonasschnelli force-pushed on Jun 3, 2015

in share/qt/Info.plist.in:None in 0a32a9347e

  29 | @@ -30,6 +30,12 @@
  30 |  
  31 |    <key>CFBundleExecutable</key>
  32 |    <string>Bitcoin-Qt</string>
  33 | +  
  34 | +  <key>CFBundleName</key>
  35 | +  <string>Bitcoin-Qt</string>

jonasschnelli commented at 8:07 AM on June 3, 2015:

For the records: this is required so that the OS can detect a manual rename of the application. If current (manually renamed) application name is != CFBundleName, it won't use localization over Base.lproj to rename the application display name.

laanwj added the label Mac on Jun 3, 2015

laanwj merged this on Jun 3, 2015

laanwj closed this on Jun 3, 2015

laanwj referenced this in commit 87406aa735 on Jun 3, 2015

laanwj commented at 1:11 PM on June 3, 2015: member

Backported to 0.11 via 4d435d1c9a8b92503fddc38c444511b9bb2a4bf7 6145fdf47e7c4e222c6d5b5abad2cd320ddc2648 .

laanwj referenced this in commit 4d435d1c9a on Jun 3, 2015

laanwj referenced this in commit 6145fdf47e on Jun 3, 2015

MarcoFalke locked this on Sep 8, 2021