fix rpcmining/getblocktemplate univalue transition logic error #6234

pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:2015/06/univalue_fix changing 1 files +1 −1

jonasschnelli commented at 7:42 PM on June 4, 2015: contributor

Reported by @sdaftuar (Thanks!).

This fixes a bug that was included in #6121 during the transition from Json Spirit to UniValue.
fix rpcmining/getblocktemplate univalue transition logic error ef5fca8b80
sdaftuar commented at 7:45 PM on June 4, 2015: member

Verified this fixes getblocktemplate_proposals.py, looks good to me.
jonasschnelli commented at 7:50 PM on June 4, 2015: contributor

Here is the code line before the transition (before #6121) to verify the change: https://github.com/bitcoin/bitcoin/blob/0.11/src/rpcmining.cpp#L403
jgarzik commented at 8:11 PM on June 4, 2015: contributor

ACK
fanquake commented at 2:15 AM on June 5, 2015: member

utACK
laanwj added the label RPC on Jun 5, 2015
laanwj merged this on Jun 5, 2015
laanwj closed this on Jun 5, 2015
laanwj referenced this in commit d38cd47fe3 on Jun 5, 2015
laanwj commented at 4:07 AM on June 5, 2015: member

Thanks
zkbot referenced this in commit a2e69fac97 on Feb 5, 2017
zkbot referenced this in commit 50807c5dc4 on Feb 7, 2017
zkbot referenced this in commit 9a6ebaba36 on Feb 10, 2017
zkbot referenced this in commit a7b8d93656 on Feb 10, 2017
zkbot referenced this in commit e51bd1b556 on Feb 10, 2017
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels