build: Remove -DBOOST_SPIRIT_THREADSAFE #6316

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2015_06_smells_like_boost_spirit changing 2 files +1 −2

laanwj commented at 6:26 AM on June 21, 2015: member

Now that boost spirit is no longer used, -DBOOST_SPIRIT_THREADSAFE doesn't need to be passed to the compiler anymore.
laanwj added the label Build system on Jun 21, 2015
jgarzik commented at 6:48 AM on June 21, 2015: contributor

ACK

FYI src/rpcprotocol.cpp has a mention of json-spirit in a comment (a URL) also
jonasschnelli commented at 10:15 AM on June 21, 2015: contributor

ACK. Agree with jgarzik on the removal of rpcprotocol.cpp L254 in this PR.
Diapolo commented at 10:41 AM on June 21, 2015: none

There also is a comment in univalue.h, perhaps related?

// The following were added for compatibility with json_spirit. // Most duplicate other methods, and should be removed.
fanquake commented at 10:42 AM on June 21, 2015: member

utACK
jonasschnelli commented at 10:45 AM on June 21, 2015: contributor

@Diapolo: right. UniValue has some json_spirit compatibility functions which should be removed/changed (but not in this PR). Also some functions should be renamed IsNull() vs get_str() looks after a json_spirit compatibility relict.

build: Remove -DBOOST_SPIRIT_THREADSAFE

Now that boost spirit is no longer used, `-DBOOST_SPIRIT_THREADSAFE`
doesn't need to be passed to the compiler anymore.

b6668209aa

Contributors

Labels