qt/scicon: Avoid warnings about unused MakeSingleColorImage #6328

pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:scicon_warnings changing 1 files +9 −3

luke-jr commented at 9:58 PM on June 23, 2015: member

A cleaner alternative to #6327
qt/scicon: Avoid warnings about unused MakeSingleColorImage 12cbf208d7
Diapolo commented at 6:04 AM on June 24, 2015: none

+9 / -3 yours +7 / -7 mine :-P

Well I like mine better, as I removed an #ifdef ;).
jonasschnelli commented at 6:31 AM on June 24, 2015: contributor

ACK
laanwj commented at 6:27 AM on June 25, 2015: member

We had this discussion before, shortly ago: #6143

For the sake of making sure as much code gets compiled for every platform, logic that does not use specific platform-dependent APIs (and thus potentially compiles on other platforms) should not be in platform-specific #ifdefs.

E.g. use MACOSX/WINDOWS to determine a UIPlatformStyle enum once, then pass that on. This could be overridden for testing. This would also apply to things such as "display images on buttons" which are currently #ifdefed.

(Or instead of an enum: this could work like NetworkStyle, where the class itself contains a list of platform specific customization flags, e.g. showImagesOnButton, colorizeIcons, etc)
laanwj added the label GUI on Jun 25, 2015
laanwj referenced this in commit 3c8c497526 on Jul 28, 2015
laanwj referenced this in commit 287b3bce7b on Jul 28, 2015
laanwj commented at 2:48 PM on July 28, 2015: member

Closing in favor of #6487, which implements the approach outlined in my above post.
laanwj closed this on Jul 28, 2015
laanwj referenced this in commit 07810e4e6c on Jul 29, 2015
laanwj referenced this in commit eec7757445 on Jul 31, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#6327 [Qt] fix unused function warning in scicon.cpp #6487 qt: Introduce PlatformStyle