doc: Update comments for AreInputsStandard to match code #32129

pull ajtowns wants to merge 1 commits into bitcoin:master from ajtowns:202503-areinputstd-comment changing 1 files +11 −13
  1. ajtowns commented at 9:09 AM on March 24, 2025: contributor

    The comment about extra data stuffed in scriptSigs was introduced in #4365 which introduced ScriptSigArgsExpected(), and became incorrect after #7387 / #7453 (checks are now performed by SCRIPT_VERIFY_CLEANSTACK during script validation and IsPushOnly() in IsStandardTx()). Drops the details on what a p2sh with many checksigs would look like, which was already done in #4365, but only for main.cpp not the duplicated comment in main.h, which was merged into policy/policy.cpp in #6335 and later moved to the right place in #10682.

  2. DrahtBot commented at 9:09 AM on March 24, 2025: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32129.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK instagibbs, darosior

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  3. DrahtBot added the label Docs on Mar 24, 2025
  4. in src/policy/policy.cpp:175 in 0f6e02dc7e outdated 
     183 | - * which will get accepted into blocks. The redemption
 184 | - * script can be anything; an attacker could use a very
 185 | - * expensive-to-check-upon-redemption script like:
 186 | - *   DUP CHECKSIG DROP ... repeated 100 times... OP_1
 187 | + * This does two things:
 188 | + *  * Prevents mempool acceptance of spends of future
    instagibbs commented at 1:19 PM on March 24, 2025:

    It's still filtering other types of non-standard scripts, which also protects against the same issue of lots of operations (in addition to offering upgrade hooks)

    ajtowns commented at 8:59 AM on March 26, 2025:

    Added some text.

  5. darosior commented at 1:54 PM on March 24, 2025: member

    Concept ACK

  6. doc: Update comments for AreInputsStandard to match code 52ede28a8a
  7. ajtowns force-pushed on Mar 26, 2025
  8. instagibbs commented at 1:36 PM on March 26, 2025: member

    ACK 52ede28a8adb2c2d44d7f800bbfbef8aed86070e

  9. DrahtBot requested review from darosior on Mar 26, 2025
  10. darosior approved
  11. darosior commented at 1:40 PM on March 26, 2025: member

    ACK 52ede28a8adb2c2d44d7f800bbfbef8aed86070e

  12. fanquake merged this on Mar 27, 2025
  13. fanquake closed this on Mar 27, 2025
  14. sedited referenced this in commit a9c46ce3c3 on Apr 24, 2025
  15. stickies-v referenced this in commit 772a33e052 on May 23, 2025
  16. yuvicc referenced this in commit 069643f094 on Jul 6, 2025
  17. bug-castercv502 referenced this in commit 5b0af4b944 on Sep 28, 2025
  18. Kino1994 referenced this in commit 260bd33fd5 on Jun 28, 2026
  19. BigcoinBGC referenced this in commit b98bf0c86b on Jun 30, 2026
  20. bitcoin locked this on Jul 30, 2026
Contributors
ajtownsDrahtBotinstagibbsdarosior
Labels
Docs
Linked (view graph)
#4365 Relax IsStandard rules for pay-to-script-hash transactions#6335 MOVEONLY: Policy: Move some policy code#7387 Get rid of inaccurate ScriptSigArgsExpected#7453 [0.13] Missing patches from 0.12#10682 Trivial: Move the AreInputsStandard documentation next to its implementation
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-08-17 03:51 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me