depends: non-qt bumps for 0.12 #6373

pull theuni wants to merge 5 commits into bitcoin:master from theuni:0.12bumps changing 5 files +12 −16

theuni commented at 5:22 PM on July 3, 2015: member
These are all of the possible bumps for 0.12, qt and openssl excluded. I'm not advocating taking all of these, just listing them all in one place for discussion. Each is a separate commit so that the undesired ones can be easily dropped.
- boost 1.55.0 to 1.58.0: This one's been discussed and I think we're in favor of taking it.
- qrencode 3.4.3 to 3.4.4: changelog - I can't find specifically what changed, need to compare the sources.
- protobuf 2.5.0 to 2.6.1: changelog1, changelog2 - This one may be risky, might be better to just leave it alone
- ccache to 3.1.9 to 3.2.2: changelog - Looks good
- miniupnpc 1.9.20140701 to 1.9.20150609: changelog
depends: bump boost to 1.58.0 4bdad99f50
depends: bump miniupnpc to 1.9.20150609 00c5a73136
depends: bump ccache to 3.2.2 d5b1851743

depends: bump protobuf to 2.6.1

Also change the download source from googlecode to github.

142ee60a89

theuni force-pushed on Jul 3, 2015
theuni force-pushed on Jul 3, 2015
depends: bump qrencode to 3.4.4 eb4f35dc7d
fanquake commented at 12:45 AM on July 4, 2015: member

This should show you the qrencode changes. https://github.com/fukuchi/libqrencode/compare/055f441af7eaa38cc794fe5a2e5bb236bbd54661...3.4
luke-jr commented at 12:49 AM on July 4, 2015: member

Probably should wait until we're closer to rc1 before bumping, in case there's more fixes?
laanwj commented at 4:04 PM on July 6, 2015: member

@luke-jr Bumping sooner has the advantage over doing it last-minute that at least the new versions can get some longer testing.
laanwj commented at 3:21 PM on July 10, 2015: member

I'm fine with upgrading all of those.

Though I agree that libprotobuf is the most risky of the bunch.
theuni commented at 5:53 PM on July 10, 2015: member

@luke-jr Yes, I agree with @laanwj. Bumping these early means they get more testing. If obvious bugfixes come in closer to release, we can certainly still pull them in.
jonasschnelli commented at 8:39 PM on July 10, 2015: contributor

Also agreed with @laanwj to take this in as soon as possible. Tried a gitian build with this PR: https://builds.jonasschnelli.ch/pulls/6373/
laanwj added the label Build system on Jul 15, 2015
laanwj commented at 9:00 AM on July 15, 2015: member

ACK
laanwj merged this on Jul 15, 2015
laanwj closed this on Jul 15, 2015
laanwj referenced this in commit 1ae3196c38 on Jul 15, 2015

Diapolo commented at 10:10 AM on July 16, 2015: none

The protobuf update seems to cause warnings:

protobuf-2.6.1\dist\include\google\protobuf\wire_format_lite_inl.h:383: Warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     for (int i = 0; i < new_entries; ++i) {
                       ^

DrahtBot locked this on Sep 8, 2021

Contributors

Labels