Implement watchonly support in fundrawtransaction #6415

pull TheBlueMatt wants to merge 10 commits into bitcoin:master from TheBlueMatt:frt3 changing 22 files +272 −63

TheBlueMatt commented at 5:54 AM on July 10, 2015: member

No description provided.
TheBlueMatt commented at 5:54 AM on July 10, 2015: member

Realized I forgot to submit this after #6088....
jonasschnelli commented at 6:50 PM on July 14, 2015: contributor

Needs rebase
laanwj added the label Feature on Jul 17, 2015
TheBlueMatt force-pushed on Jul 17, 2015
TheBlueMatt force-pushed on Jul 17, 2015
Also remove pay-2-pubkey from watch when adding a priv key cfc3dd3428
Split up importaddress into helper functions 983d2d90af
Add p2sh option to importaddress to import redeemScripts 907a425aa5
Add importpubkey method to import a watch-only pubkey a1d7df3236
Update importaddress help to push its use to script-only 5c17059872

Add have-pubkey distinction to ISMINE flags

This indicates that, eg, we have a public key for a key which may
be used as a pay-to-pubkey-hash. It generally means that we can
create a valid scriptSig except for missing private key(s) with
which to create signatures.

d3354c52d7

Add logic to track pubkeys as watch-only, not just scripts f5813bdd3e

Implement watchonly support in fundrawtransaction

Some code and test cases stolen from
Bryan Bishop <bryan@ledgerx.com> (pull #5524).

6bdb474dc9

TheBlueMatt force-pushed on Jul 20, 2015
jgarzik commented at 7:11 PM on July 23, 2015: contributor

ut ACK
SQUASH "Add have-pubkey distinction to ISMINE flags" 428a898acd
SQUASH "Implement watchonly support in fundrawtransaction" d04285430d
sipa commented at 3:03 PM on August 10, 2015: member

Untested ACK.
sipa commented at 4:13 PM on August 10, 2015: member

Hmm, do you actually need to have the full CPubKey object available? Just marking a particular key id as "trust me, i can sign this" should be enough, or am i missing something?
sipa commented at 4:44 PM on August 10, 2015: member

Ignore me, the dummy signer needs it. Nice.
laanwj commented at 2:14 PM on August 14, 2015: member

utACK
laanwj merged this on Aug 14, 2015
laanwj closed this on Aug 14, 2015
laanwj referenced this in commit ddd8d80c63 on Aug 14, 2015
bitcartel referenced this in commit 4c70e15d8c on Apr 2, 2019
str4d referenced this in commit 5c76b1df64 on Nov 14, 2019
str4d referenced this in commit 7bc673977a on Nov 14, 2019
zkbot referenced this in commit 5e26d48a39 on Dec 3, 2019
str4d referenced this in commit de2eddd21d on Dec 3, 2019
str4d referenced this in commit ebd0669816 on Dec 3, 2019
str4d referenced this in commit 3c8c8009db on Dec 4, 2019
str4d referenced this in commit 82beb18901 on Dec 4, 2019
furszy referenced this in commit bf132c4e6a on Jun 18, 2020
furszy referenced this in commit fe31b31eec on Jun 18, 2020
furszy referenced this in commit 0724bbbad2 on Jun 28, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Labels