OSX - Still displays as qt in spotlight #6463

drazisil commented at 1:40 PM on July 22, 2015: none

Per https://github.com/bitcoin-dot-org/bitcoin.org/pull/968 still shows as bitcoin qt in spotlight.

I located #6116 which appears to have fixed it everywhere else, but it looks like this was missed.

I believe it's https://github.com/bitcoin/bitcoin/blob/master/share/qt/Info.plist.in that's causing it, but I'm not a mac programmer and don't feel safe opening an untested PR.

<key>CFBundleName</key>
  <string>Bitcoin-Qt</string>`

https://developer.apple.com/library/ios/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html

laanwj added the label Mac on Jul 22, 2015

laanwj added the label Build system on Jul 22, 2015

jonasschnelli commented at 2:06 PM on July 22, 2015: contributor

Nice catch. Changing the CFBundleName is not possible with breaking other things. I think it's possible to fix this because if you search with spotlight after application which also uses localization (like Disk Utility) it works also. Will have a look at it soon.

jonasschnelli commented at 9:14 AM on July 23, 2015: contributor

I could locate the root cause of this problem. It looks like, that our Base.lproj (localization base instead of directly using English.lproj, etc.) does not work for spotlight (https://github.com/bitcoin/bitcoin/blob/d4a910c31e3a14537e0bf9821fc4a9d95b44a18d/Makefile.am#L22).

A fix would be to copy the Base.lproj folder to serval supported languages (English.lproj, German.lproj, fr.lproj, etc.). We could take the transfix supported ISO codes as folder name source. What do you think @theuni ?

laanwj commented at 6:35 AM on July 24, 2015: member

Sounds to me like overkill for a silly naming issue. And to have to to enumerate every possible language is a rabbit hole with no end.

jonasschnelli commented at 8:16 AM on July 24, 2015: contributor

Yeah. Agree. It's a overkill to fix a upstream bug. OSX's Spotlight should also respect the Base.lproj localization. I'll file a bug upstream.

jonasschnelli commented at 8:33 AM on July 24, 2015: contributor

Upstream Apple OSX Bug number: 21978972

laanwj added the label Upstream on Feb 9, 2016

fanquake commented at 10:45 AM on June 22, 2016: member

@jonasschnelli Given that it's not possible to browse other peoples Apple bug reports, could you check in and see what the status of it is?

drazisil commented at 7:46 PM on November 27, 2016: none

@jonasschnelli Reviewing my old open Issues, is Upstream Apple OSX Bug number: 21978972 still active?

jonasschnelli commented at 11:02 AM on November 29, 2016: contributor

Can't find BUG 21978972 anymore. Maybe they deleted it. Bug is still present in OSX 10.12. <img width="660" alt="bildschirmfoto 2016-11-29 um 12 01 19" src="https://cloud.githubusercontent.com/assets/178464/20707397/98be007a-b62b-11e6-9374-66b459117eb8.png">

drazisil commented at 3:20 PM on April 3, 2017: none

Any update? You can close if you want.

drazisil closed this on Apr 27, 2017

laanwj commented at 2:06 PM on April 27, 2017: member

Well if it is still an issue it should not be closed

drazisil commented at 2:17 PM on April 27, 2017: none

I don't know if it still is, and I don't use Bitcoin on macOS anymore so can't test. I was just tired of looking at it in my list, it's nearly 2 years old with no activity. I'll leave it open then.

drazisil reopened this on Apr 27, 2017

jonasschnelli commented at 5:50 PM on April 27, 2017: contributor

Not sure if I miss something, but is there a reason why we can't rename the binary from Bitcoin-Qt to Bitcoin-Core (during DMG packaging) and set the corresponding CFBundleName? Ah. I remember, we wanted to keep the "replicability feature" (when you drag'n'drop a new Bitcoin-Core version into the /Application folder). If we rename, there will be suddenly two Bitcoin-Core apps.

drazisil commented at 3:50 PM on December 16, 2017: none

Any update on this?

drazisil commented at 2:59 PM on April 30, 2019: none

This is a 4 year old bug. I don't use Bitcoin anymore, I'm not sure if Spotlight is even a thing still. If anyone still finds this an issue, they can open a new Issue.

drazisil closed this on Apr 30, 2019

Sjors commented at 3:30 PM on April 30, 2019: member

It's still an issue, but we don't want to rename the bundle (I don't know if that's really unavoidable).

drazisil commented at 4:15 PM on April 30, 2019: none

Ok, I guess I'll leave it open then. :sigh:

drazisil reopened this on Apr 30, 2019

drazisil commented at 2:46 PM on December 22, 2019: none

Please either change the bundle, or make a note that you have no plans to and close the issue.

There is no reason this bug should be open this long.

Sjors commented at 2:56 PM on December 22, 2019: member

@drazisil this is an open source project. Either make a pull request, read some Apple documentation to clarify what is and isn't possible, or accept that things are not magically getting fixed.

drazisil commented at 3:13 PM on December 22, 2019: none

I do accept what is not getting fixed. I have tried to close this bug report several times. I'm sorry my message came across the way it did. Happy holidays 🙂

drazisil closed this on Dec 22, 2019

DrahtBot locked this on Dec 16, 2021