This is pretty trivial, but if there's an error here we'll leak a file descriptor. Changed it to always close the file.
Avoid leaking file descriptors in RegisterLoad #6488
pull casey wants to merge 1 commits into bitcoin:master from casey:register-load-filehandle-leak changing 1 files +4 −3-
casey commented at 6:07 PM on July 28, 2015: contributor
-
17ac0f4025
Avoid leaking file descriptors in RegisterLoad
This is pretty trivial, but if there's an error here we'll leak a file descriptor. Changed it to always close the file.
-
TheBlueMatt commented at 8:59 PM on July 28, 2015: member
utACK
-
laanwj commented at 6:11 AM on July 29, 2015: member
utACK. Looks good to me. Non-RAII C types are a continuing exception-safety hazard.
- laanwj added the label Utils on Jul 29, 2015
-
jonasschnelli commented at 7:04 AM on July 29, 2015: contributor
Nice catch. utACK.
- laanwj merged this on Jul 29, 2015
- laanwj closed this on Jul 29, 2015
- laanwj referenced this in commit 7cbed7fa28 on Jul 29, 2015
- casey deleted the branch on Jul 29, 2015
-
jgarzik commented at 7:39 PM on July 29, 2015: contributor
posthumous ut ACK
- MarcoFalke locked this on Sep 8, 2021
Contributors
Labels