[Qt] show client user agent in debug window #6529

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:Qt_subver changing 4 files +54 −22
  1. Diapolo commented at 1:44 PM on August 6, 2015: none

    subver

    I added the same indentation to the subversion as we have for the lib versions, this is just an obsolete screenshot.

  2. laanwj commented at 4:33 PM on August 6, 2015: member

    ACK

  3. laanwj added the label GUI on Aug 6, 2015
  4. fanquake commented at 4:55 PM on August 6, 2015: member

    Tested ACK screen shot 4

  5. laanwj commented at 6:25 AM on August 7, 2015: member

    Small nit: let's call it "User agent" instead of "Client subversion". I can see "subversion" resulting in quite funny translations, and more people will understand it by comparing it to HTTP user agent (that's also why we use option -uacomment)

  6. paveljanik commented at 6:28 AM on August 7, 2015: contributor

    Do we need starting and trailing / in Client version and User agent/Client subversion at all?

  7. laanwj commented at 6:31 AM on August 7, 2015: member

    IMO, yes. Don't try to be smart and just report as it is sent to the P2P network.

  8. paveljanik commented at 6:43 AM on August 7, 2015: contributor

    ACK

  9. MarcoFalke commented at 10:24 AM on August 7, 2015: member

    +1 for User Agent (The Peers-tab in the debug window already calls it that way)

  10. [Qt] show client user agent in debug window 54bd28fa75
  11. Diapolo renamed this:
    [Qt] show client subversion in debug window
    [Qt] show client user agent in debug window
    on Aug 7, 2015
  12. Diapolo commented at 12:02 PM on August 7, 2015: none

    Updated to User Agent.

  13. jonasschnelli commented at 12:32 PM on August 7, 2015: contributor

    Tested ACK. +1 for user agent. <img width="1112" alt="bildschirmfoto 2015-08-07 um 14 31 29" src="https://cloud.githubusercontent.com/assets/178464/9135746/0995d60a-3d11-11e5-891c-e5fd3d41e0d6.png">

  14. laanwj merged this on Aug 7, 2015
  15. laanwj closed this on Aug 7, 2015
  16. laanwj referenced this in commit c0f66ce44a on Aug 7, 2015
  17. Diapolo deleted the branch on Aug 8, 2015
  18. DrahtBot locked this on Aug 16, 2022
Contributors
DiapololaanwjfanquakepaveljanikMarcoFalkejonasschnelli
Labels
GUI
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me