Fix spelling mistakes in code documentation #6544

pull maaku wants to merge 2 commits into bitcoin:master from maaku:spellfix changing 2 files +2 −2
  1. maaku commented at 1:13 AM on August 11, 2015: contributor

    See commits for details. Does change the test binary due to JSON strings.

  2. Correct a possibly intentional pun that is nevertheless hard to read: "two times of nLockTime." What is meant is that there are two kinds, or categories of nLockTime. e846b2a1e9
  3. Fix spelling mistake in -> if. c5c1edfe60
  4. Diapolo commented at 7:04 AM on August 11, 2015: none
  5. dcousens commented at 7:48 AM on August 11, 2015: contributor

    @Diapolo what is that repository by comparison? Why can't it be merged here? I don't see any notes RE the above in https://github.com/bitcoin/bitcoin#development-process, so please forgive me if I've missed something.

  6. fanquake commented at 7:50 AM on August 11, 2015: member

    @dcousens Please don't comment on multiple issues asking the same question; it just results in email spam.. The trivial next repository was set up to handle trivial code changes and to try keep some of the "noise" out of the main repository.

  7. dcousens commented at 8:17 AM on August 11, 2015: contributor

    @fanquake sure. I removed the superfluous comment in #6543. There is no mention of that process in the README, is it listed somewhere officially?

    Also, if they are legitimate fixes, why not just merge any way? If you want to limit the number of "trivial" commits, why not use a branch [in this repository] and just merge it after some cap of trivial commits has been reached? It seems redundant to use another repository for changes to this code base.

  8. fanquake commented at 8:48 AM on August 11, 2015: member

    @dcousens The repo is still somewhat experimental. It's had some traffic, and been merged back into the main repository at least three time now, see #6135, #6004 and the original merge in #5731. Given that we're pointing people to it we probably should mention it in the documentation. Feel free to submit a pull request (to the main repo) to add some notes.

    Using a separate branch in this repository doesn't solve the "noise" problem. Anyone following this repository would still get emailed for every trivial pull request, and every comment each trivial pull.

  9. jonasschnelli commented at 3:32 PM on August 17, 2015: contributor

    ACK. But should go over @theuni s trivial branch.

  10. dcousens commented at 11:48 PM on August 17, 2015: contributor

    @fanquake the joys of a monolithic code base. Shall we put it in the README?

  11. laanwj commented at 3:35 PM on August 19, 2015: member

    Just going to merge this now. But yes we should get the trivial branch running again @theuni, please submit there next time.

  12. laanwj merged this on Aug 19, 2015
  13. laanwj closed this on Aug 19, 2015

  14. laanwj referenced this in commit ef30389e2a on Aug 19, 2015
  15. maaku deleted the branch on Jan 6, 2016
  16. luke-jr referenced this in commit ddbbdabc7a on Jan 9, 2016
  17. luke-jr referenced this in commit e1c65a5b82 on Jan 9, 2016
  18. luke-jr referenced this in commit b326b33cd8 on Jan 10, 2016
  19. luke-jr referenced this in commit c5d0e7ab48 on Jan 10, 2016
  20. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 18:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me