limitedmap fixes and tests #6561

pull casey wants to merge 3 commits into bitcoin:master from casey:limitedmap changing 3 files +113 −8

casey commented at 4:22 PM on August 17, 2015: contributor

This PR consists of three commits.

The first fixes a bug where the size of a limited map was actually one less than the maximum size set. This shouldn't matter at all for the existing code, since there is only one limitedmap, and its size is very large.

The second disallows unlimited limited maps, since that doesn't make very much sense, and simplifies the code a little bit. (I'm not too attached to this, in case anyone doesn't like this change I can just remove it.)

The third adds unit tests for limitedmap, which were previously absent.

I elected to leave the commits unsquashed for review, since they're logically separate, but I can squash if desired.
Make limited map actually respect max size fd2d862fbc
Disallow unlimited limited maps 8b06894194
Add limitedmap test 7bd57bb1d7
casey renamed this:
~~Limitedmap fixes~~
limitedmap fixes and tests
on Aug 17, 2015
sipa commented at 9:20 PM on August 17, 2015: member

ACK
TheBlueMatt commented at 10:46 PM on August 17, 2015: member

utACK
laanwj commented at 1:43 PM on August 19, 2015: member

utACK. Thanks a lot for adding tests!
laanwj merged this on Aug 19, 2015
laanwj closed this on Aug 19, 2015
laanwj referenced this in commit e08a7d9d40 on Aug 19, 2015
casey deleted the branch on Aug 19, 2015
dcousens commented at 1:19 AM on August 20, 2015: contributor

Is it worth adding a test to verify that insert after max_size is reached, it doesn't increment size? (Happy to do this)
casey commented at 2:52 PM on August 20, 2015: contributor

It does this already, unless you were thinking of a more substantial test: 11 elements are added (one one off, and then ten in a loop) and then line 39 checks that there are only 10 elements.
dcousens commented at 10:03 PM on August 20, 2015: contributor

Sorry, I missed that first insert @casey. utACK :)
luke-jr referenced this in commit 4849c1f156 on Jan 9, 2016
luke-jr referenced this in commit 4d09290b2c on Jan 9, 2016
luke-jr referenced this in commit 49e9a861eb on Jan 10, 2016
zkbot referenced this in commit e10008da66 on Feb 18, 2021
zkbot referenced this in commit 777deea264 on Feb 19, 2021
zkbot referenced this in commit b62e35dee8 on Feb 19, 2021
DrahtBot locked this on Sep 8, 2021

Contributors