update build-unix.md (build bdb). Need autogen.sh to configure bdb #6611

pull Altoidnerd wants to merge 1 commits into bitcoin:master from Altoidnerd:master changing 1 files +2 −1

Altoidnerd commented at 11:18 AM on September 1, 2015: contributor

Obviously if a user hasn't ready run autogen.sh, ./configure returns file not found. Do the instructions seem to presume you have already built bitcoin? I don't think they do.

It's a small thing but beginners would have trouble.
Altoidnerd renamed this:
~~need autogen.sh to configure bdb~~
update build-unix.md (build bdb). Need autogen.sh to configure bdb
on Sep 1, 2015
jonasschnelli commented at 11:26 AM on September 1, 2015: contributor

At this point, probably most user had already run ./autogen.sh. But calling ./autogen.sh twice is non problematic and better twice than never.

ACK.
Altoidnerd commented at 11:51 AM on September 1, 2015: contributor

This is also a more complicated section of the doc, so perhaps the presumption is of an advanced user.

It just depends on how you think of docs and their purpose. I always try to write them as if the reader is typing the commands without knowing why. A very good doc will get the job done in that case too.
laanwj commented at 1:04 PM on September 1, 2015: member

It's just an illustration how to point bitcoin's configure at your own BDB - not a general description how to do the autotools configure process - that should have been described earlier, so it may be better to refer back But no problem with this change...
fanquake commented at 6:50 AM on September 2, 2015: member

ACK. Please squash your commits.
paveljanik commented at 8:15 AM on September 2, 2015: contributor

ACK after squashing.
Altoidnerd commented at 8:51 AM on September 2, 2015: contributor
sorry ... I tried
```
git rebase -i HEAD~2 
git push origin master --force
```
Do I have to resubmit the PR now?
jonasschnelli commented at 8:59 AM on September 2, 2015: contributor

Please don't resubmit/re-create the PR. Just use git rebase -i HEAD~2, pick (p) the older commit and squash (s) the newer commit, ... than force push again.

Update build-unix.md

If a user hasn't ready run autogen.sh, configure doesn't yet exist.  Do the instructions seem to presume you have already built bitcoin?  I don't think they do.

Would stifle beginners.

Update build-unix.md

5b85126863

Altoidnerd commented at 9:15 AM on September 2, 2015: contributor

@jonasschnelli very good thank you.
laanwj merged this on Sep 3, 2015
laanwj closed this on Sep 3, 2015
laanwj referenced this in commit 5e1ec3b5be on Sep 3, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors