depends: bump miniupnpc and ccache #6619

pull fanquake wants to merge 2 commits into bitcoin:master from fanquake:depends-bump changing 2 files +4 −4

fanquake commented at 2:26 PM on September 2, 2015: member

@theuni mentioned we can bump miniupnpc to 1.9.20150730 in #6583. release notes

$Id: Changelog.txt,v 1.212 2015/07/23 20:41:50 nanard Exp $
miniUPnP client Changelog.
2015/07/23:
  split getDevicesFromMiniSSDPD
  add ttl argument to upnpDiscover() functions
  increments API_VERSION to 14

2015/07/22:
  Read USN from SSDP messages.

2015/07/15:
  Check malloc/calloc

2015/06/16:
  update getDevicesFromMiniSSDPD() to process longer minissdpd
    responses

We could also bump ccache to 3.2.3 (currently 3.2.2) release notes

ccache 3.2.3
Release date: 2015-08-16

New features and improvements
Added support for compiler option -gsplit-dwarf.

Bug fixes
Support external zlib in nonstandard directory.

Avoid calling exit() inside an exit handler.

Let exit handler terminate properly.

Bail out on compiler option --save-temps in addition to -save-temps.

Only log "Disabling direct mode" once when failing to read potential include files.

qrencode (3.44) and protobuf (2.6.1) are still both the most recent releases.

Boost 1.59.0 is out, release notes here

jonasschnelli commented at 3:33 PM on September 2, 2015: contributor

Tried a gitian build... seems to be a hash/checksum issue somewhere: https://builds.jonasschnelli.ch/pulls/6619/ https://builds.jonasschnelli.ch/pulls/6619/build-linux.log
fanquake commented at 3:39 PM on September 2, 2015: member
Can you manually download http://miniupnp.free.fr/files/miniupnpc-1.9.20150730.tar.gz, and see if you get a different SHA256?
```
7730c60cdddb6c7788f5c068a52cf55db8cee126304f86becd9a52c825b8cdc2
```

jonasschnelli commented at 3:42 PM on September 2, 2015: contributor

Jup. Is different.

jonasschnelli$ openssl dgst -sha256 miniupnpc-1.9.20150730.tar.gz 
SHA256(miniupnpc-1.9.20150730.tar.gz)= 1d64fab1fd3b4c8545139341ba197f19329a863f4f21b578fc2a228ab586a604

fanquake commented at 3:46 PM on September 2, 2015: member

Interesting, can someone else download and confirm I'm generating the wrong hash?

fanquake$ openssl dgst -sha256 miniupnpc-1.9.20150730.tar.gz 
SHA256(miniupnpc-1.9.20150730.tar.gz)= 7730c60cdddb6c7788f5c068a52cf55db8cee126304f86becd9a52c825b8cdc2

fanquake$ shasum -a 256 miniupnpc-1.9.20150730.tar.gz 
7730c60cdddb6c7788f5c068a52cf55db8cee126304f86becd9a52c825b8cdc2  miniupnpc-1.9.20150730.tar.gz

theuni commented at 3:47 PM on September 2, 2015: member

cory@cory-i7:/tmp$ sha256sum miniupnpc-1.9.20150730.tar.gz 
1d64fab1fd3b4c8545139341ba197f19329a863f4f21b578fc2a228ab586a604  miniupnpc-1.9.20150730.tar.gz

fanquake force-pushed on Sep 2, 2015

laanwj commented at 3:54 PM on September 2, 2015: member

Just downloaded:

Sha256: 1d64fab1fd3b4c8545139341ba197f19329a863f4f21b578fc2a228ab586a604  miniupnpc-1.9.20150730.tar.gz
Size: 81431

Would be very interested in @fanquake's variant.

depends: bump miniupnpc to 1.9.20150730 888c595cff
depends: bump ccache to 3.2.3 42cf08905f
fanquake force-pushed on Sep 2, 2015
fanquake commented at 4:17 PM on September 2, 2015: member

I've amended the miniupnpc commit @laanwj If I download using the depends system, or wget directly, I get the correct file and hash. However if I download using the exact same link in Chrome, I'm getting a different 400kb file..
theuni commented at 4:20 PM on September 2, 2015: member

@fanquake same! firefox is the good hash, chromium is different (7730c60cdddb6c7788f5c068a52cf55db8cee126304f86becd9a52c825b8cdc2, same as yours). Investigating now.

theuni commented at 4:32 PM on September 2, 2015: member

ok, mystery solved, though it only raises further questions:

cory$ sha256sum miniupnpc-1.9.20150730.tar.gz 
1d64fab1fd3b4c8545139341ba197f19329a863f4f21b578fc2a228ab586a604  miniupnpc-1.9.20150730.tar.gz
cory$ gzip -d miniupnpc-1.9.20150730.tar.gz 
cory$ sha256sum miniupnpc-1.9.20150730.tar 
7730c60cdddb6c7788f5c068a52cf55db8cee126304f86becd9a52c825b8cdc2  miniupnpc-1.9.20150730.tar

laanwj added the label Build system on Sep 3, 2015
laanwj commented at 1:54 PM on September 4, 2015: member

ACK
laanwj commented at 4:08 PM on September 23, 2015: member

This is the complete diff between the two miniupnp versions: https://gist.github.com/laanwj/18e5da2b68f3a7127e27
laanwj merged this on Sep 25, 2015
laanwj closed this on Sep 25, 2015
laanwj referenced this in commit 486270854e on Sep 25, 2015
theuni commented at 3:57 PM on September 25, 2015: member

post-merge ACK
fanquake deleted the branch on May 12, 2016
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#6583 add support for miniupnpc api version 14