timedata: Prevent warning overkill #6728

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2015_09_warning_overkill changing 1 files +1 −2

laanwj commented at 2:44 PM on September 27, 2015: member

The "please check your computer's data and time" message when the clock deviates from the network currently generates an overkill of messages :-)

orion@lethe:~/bitcoin$ src/bitcoind
Warning: Warning: Please check that your computer's date and time are correct! If your clock is wrong Bitcoin Core will not work properly.

In the log:

2015-09-27 16:24:13 *** Warning: Please check that your computer's date and time are correct! If your clock is wrong Bitcoin Core will not work properly.
2015-09-27 16:24:13 Warning: Warning: Please check that your computer's date and time are correct! If your clock is wrong Bitcoin Core will not work properly.

Remove one level of 'Warning:' and reduce to one log message.

Edit: An open question is whether this message should be translated at all, currently it is.

timedata: Prevent warning overkill

The "please check your computer's data and time" message when the clock
deviates from the network currently generates an overkill of messages:

    orion@lethe:~/bitcoin$ src/bitcoind
    Warning: Warning: Please check that your computer's date and time are correct! If your clock is wrong Bitcoin Core will not work properly.

In the log:

    2015-09-27 16:24:13 *** Warning: Please check that your computer's date and time are correct! If your clock is wrong Bitcoin Core will not work properly.
    2015-09-27 16:24:13 Warning: Warning: Please check that your computer's date and time are correct! If your clock is wrong Bitcoin Core will not work properly.

Remove one level of 'Warning:' and reduce to one log message.

9fea833a12

laanwj added the label Trivial on Sep 27, 2015
fanquake commented at 6:38 AM on September 28, 2015: member

ACK
jonasschnelli commented at 6:53 AM on September 28, 2015: contributor

utACK.
MarcoFalke commented at 8:43 AM on September 28, 2015: member

Tested ACK 9fea833 on fed23 with bitcoind.

Though, QT will crash (regardless of this PR).
jonasschnelli commented at 8:47 AM on September 28, 2015: contributor

Though, QT will crash (regardless of this PR).

Can you explain that more detailed? Why is QT crashing?
fanquake commented at 8:51 AM on September 28, 2015: member

Probably better to open a separate issue, if there isn't one already.

On Monday, September 28, 2015, Jonas Schnelli notifications@github.com wrote:

Though, QT will crash (regardless of this PR).

Can you explain that more detailed? Why is QT crashing?

— Reply to this email directly or view it on GitHub #6728 (comment).
jonasschnelli commented at 9:44 AM on September 28, 2015: contributor

Could not crash Fedora and OSX when set my local date +2 day and did 5min IBD on testnet.
MarcoFalke commented at 9:55 AM on September 28, 2015: member

Fedora 23 is alpha, so likely it's a local issue with modal dialogs on my box. Doesn't hold back this PR.
ongygy2000 commented at 12:13 PM on September 28, 2015: none

date and time are correct but still load core bitcoin network Thanks for the loyalty of the cooperation
laanwj commented at 6:16 AM on September 29, 2015: member

A GUI crash is a serious issue, however please open a new issue for that with more information: debug.log tail, any messages, traceback if possible. It cannot be related to the trivial message change here.
laanwj merged this on Sep 29, 2015
laanwj closed this on Sep 29, 2015
laanwj referenced this in commit 2b0567b002 on Sep 29, 2015
MarcoFalke commented at 6:53 PM on October 29, 2015: member

Can no longer reproduce the GUI crash...
zkbot referenced this in commit e10008da66 on Feb 18, 2021
zkbot referenced this in commit 777deea264 on Feb 19, 2021
zkbot referenced this in commit b62e35dee8 on Feb 19, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors