Changed rpc-tests.sh to rpc-tests.py in README.md #6752

pull ptschip wants to merge 1 commits into bitcoin:master from ptschip:readme changing 1 files +2 −2

ptschip commented at 3:07 PM on October 3, 2015: contributor

No description provided.
Changed rpc-tests.sh to rpc-tests.py in README.md f740e78492
paveljanik commented at 3:27 PM on October 3, 2015: contributor

Is the UTF BOM at the beginning of the file needed?
ptschip commented at 4:55 PM on October 3, 2015: contributor

i don't know, but i don't see it as related to this pull request...

On 03/10/2015 8:28 AM, paveljanik wrote:

Is the UTF BOM at the beginning of the file needed?

— Reply to this email directly or view it on GitHub #6752 (comment).
paveljanik commented at 5:08 PM on October 3, 2015: contributor

You added it in the commit in this PR, so it is related ;-) Or maybe your editor added it without you even knowing...
laanwj added the label Docs and Output on Oct 5, 2015
laanwj commented at 9:54 AM on October 5, 2015: member

heh, UTF-8 should not require BOMs
jonasschnelli commented at 10:59 AM on October 5, 2015: contributor

ACK
laanwj referenced this in commit 5f34a2510f on Oct 5, 2015
laanwj commented at 11:38 AM on October 5, 2015: member

Merged as 5f34a25 without BOM
laanwj closed this on Oct 5, 2015

paveljanik commented at 11:46 AM on October 5, 2015: contributor

BOM in the master:

bitcoin-master pavel$ hexdump -C README.md | head -1
00000000  ef bb bf 42 69 74 63 6f  69 6e 20 43 6f 72 65 20  |...Bitcoin Core |
bitcoin-master pavel$

laanwj commented at 11:52 AM on October 5, 2015: member

Yes, editorfail, these things are harder to get rid of than viruses.

Never mind, it's bullshit but I guess it doesn't get in the way of anything.
MarcoFalke commented at 11:55 AM on October 5, 2015: member

Let's just append it to the next trivial PR.
paveljanik commented at 1:58 PM on October 5, 2015: contributor

No problem for me. The diff looked weird in the GitHub PR 8)
ptschip deleted the branch on Oct 17, 2015
DrahtBot locked this on Sep 8, 2021

Contributors

Labels