Release tarball missing many files from git source

luke-jr commented at 11:25 pm on October 3, 2015: member

  0Only in from-git/: .gitattributes
  1Only in from-git/: .gitignore
  2Only in from-git/: .travis.yml
  3Only in from-git/: .tx
  4Only in from-gitian/: Makefile.in
  5Only in from-git/: README.md
  6Only in from-gitian/: aclocal.m4
  7Only in from-git/: autogen.sh
  8Only in from-gitian/build-aux: config.guess
  9Only in from-gitian/build-aux: config.sub
 10Only in from-gitian/build-aux: depcomp
 11Only in from-gitian/build-aux: install-sh
 12Only in from-gitian/build-aux: ltmain.sh
 13Only in from-gitian/build-aux/m4: libtool.m4
 14Only in from-gitian/build-aux/m4: ltoptions.m4
 15Only in from-gitian/build-aux/m4: ltsugar.m4
 16Only in from-gitian/build-aux/m4: ltversion.m4
 17Only in from-gitian/build-aux/m4: lt~obsolete.m4
 18Only in from-gitian/build-aux: missing
 19Only in from-gitian/: configure
 20Only in from-git/contrib: README.md
 21Only in from-git/contrib: bitcoin-qt.pro
 22Only in from-git/contrib: bitcoind.bash-completion
 23Only in from-git/contrib: bitrpc
 24Only in from-git/contrib: debian
 25Only in from-git/contrib: devtools
 26Only in from-git/contrib: gitian-descriptors
 27Only in from-git/contrib: gitian-downloader
 28Only in from-git/contrib: init
 29Only in from-git/contrib: linearize
 30Only in from-git/contrib/macdeploy: LICENSE
 31Only in from-git/contrib/macdeploy: README.md
 32Only in from-git/contrib/macdeploy: background.png
 33Only in from-git/contrib/macdeploy: background.psd
 34Only in from-git/contrib/macdeploy: background@2x.png
 35Only in from-git/contrib: qos
 36Only in from-git/contrib: qt_translations.py
 37Only in from-git/contrib: seeds
 38Only in from-git/contrib: spendfrom
 39Only in from-git/contrib: test-patches
 40Only in from-git/contrib: testgen
 41Only in from-git/contrib: tidy_datadir.sh
 42Only in from-git/contrib: verify-commits
 43Only in from-git/contrib: verifysfbinaries
 44Only in from-git/: depends
 45Only in from-git/doc: Doxyfile
 46Only in from-git/doc: README_osx.txt
 47Only in from-git/doc: bitcoin_logo_doxygen.png
 48Only in from-git/doc: gitian-building
 49Only in from-git/doc: travis-ci.txt
 50Only in from-git/share: certs
 51Only in from-git/share/pixmaps: addressbook16.bmp
 52Only in from-git/share/pixmaps: addressbook16mask.bmp
 53Only in from-git/share/pixmaps: addressbook20.bmp
 54Only in from-git/share/pixmaps: addressbook20mask.bmp
 55Only in from-git/share/pixmaps: bitcoin-bc.ico
 56Only in from-git/share/pixmaps: bitcoin128.png
 57Only in from-git/share/pixmaps: bitcoin128.xpm
 58Only in from-git/share/pixmaps: bitcoin16.png
 59Only in from-git/share/pixmaps: bitcoin16.xpm
 60Only in from-git/share/pixmaps: bitcoin256.png
 61Only in from-git/share/pixmaps: bitcoin256.xpm
 62Only in from-git/share/pixmaps: bitcoin32.png
 63Only in from-git/share/pixmaps: bitcoin32.xpm
 64Only in from-git/share/pixmaps: bitcoin64.png
 65Only in from-git/share/pixmaps: bitcoin64.xpm
 66Only in from-git/share/pixmaps: check.ico
 67Only in from-git/share/pixmaps: favicon.ico
 68Only in from-git/share/pixmaps: send16.bmp
 69Only in from-git/share/pixmaps: send16mask.bmp
 70Only in from-git/share/pixmaps: send16masknoshadow.bmp
 71Only in from-git/share/pixmaps: send20.bmp
 72Only in from-git/share/pixmaps: send20mask.bmp
 73Only in from-git/share/qt: extract_strings_qt.py
 74Only in from-git/share/qt: img
 75Only in from-git/share/qt: make_spinner.py
 76Only in from-git/share/qt: make_windows_icon.sh
 77Only in from-git/share/qt: protobuf.pri
 78Only in from-git/share: ui.rc
 79Only in from-git/src: .clang-format
 80Only in from-gitian/src: Makefile.in
 81Only in from-git/src/config: .empty
 82Only in from-gitian/src/config: bitcoin-config.h.in
 83Only in from-git/src/json: LICENSE.txt
 84Only in from-git/src/json: json_spirit_reader.cpp
 85Only in from-git/src/json: json_spirit_value.cpp
 86Only in from-git/src/json: json_spirit_writer.cpp
 87Only in from-git/src: obj
 88Only in from-git/src: obj-test
 89Only in from-git/src/qt: Makefile
 90Only in from-git/src/qt: bitcoinstrings.cpp
 91Only in from-git/src/qt/res/movies: makespinner.sh
 92Only in from-git/src/qt/res: spinner.png
 93Only in from-git/src/qt/res: src
 94Only in from-git/src/qt/test: Makefile
 95Only in from-git/src/secp256k1: .gitignore
 96Only in from-git/src/secp256k1: .travis.yml
 97Only in from-gitian/src/secp256k1: Makefile.in
 98Only in from-git/src/secp256k1: README.md
 99Only in from-gitian/src/secp256k1: aclocal.m4
100Only in from-gitian/src/secp256k1/build-aux: config.guess
101Only in from-gitian/src/secp256k1/build-aux: config.sub
102Only in from-gitian/src/secp256k1/build-aux: depcomp
103Only in from-gitian/src/secp256k1/build-aux: install-sh
104Only in from-gitian/src/secp256k1/build-aux: ltmain.sh
105Only in from-gitian/src/secp256k1/build-aux/m4: libtool.m4
106Only in from-gitian/src/secp256k1/build-aux/m4: ltoptions.m4
107Only in from-gitian/src/secp256k1/build-aux/m4: ltsugar.m4
108Only in from-gitian/src/secp256k1/build-aux/m4: ltversion.m4
109Only in from-gitian/src/secp256k1/build-aux/m4: lt~obsolete.m4
110Only in from-gitian/src/secp256k1/build-aux: missing
111Only in from-gitian/src/secp256k1: configure
112Only in from-git/src/secp256k1: obj
113Only in from-git/src/secp256k1/src/java: org
114Only in from-git/src/secp256k1/src/java: org_bitcoin_NativeSecp256k1.c
115Only in from-gitian/src/secp256k1/src: libsecp256k1-config.h.in
116Only in from-git/src/test: Makefile
117Only in from-git/src/test: README.md
118Only in from-git/src/test/data: README.md
119Only in from-git/src/univalue: gen.cpp

AFAIK the only difference should be additional files from autogen.sh…

laanwj added the label Build system on Oct 7, 2015

paveljanik commented at 3:29 pm on November 28, 2015: contributor

@theuni Do you know from where this difference comes? Do some of these missing files need to be listed somewhere?

laanwj commented at 1:50 pm on December 1, 2015: member

@paveljanik EXTRA_DIST etc in the makefile

MarcoFalke commented at 5:34 pm on December 1, 2015: member

Only in from-git/: autogen.sh

Are you sure this is not in from-gitian because we fixed that in #6418?

nomnombtc commented at 2:04 am on August 24, 2016: contributor

Hello,

sorry to bump this old issue, but as it is still open I figured why not. @luke-jr I am the guy who answered you earlier on reddit about the tarball here on github.

Many packagers prefer this file because it contains additional things like manpages. Then I noticed that even debian apparently builds its packages from it: (this has the same hash like this)

0% sha256sum *.gz
1852581d21716b74e0539f7fd2f9c17f5506f1c21c5cec6642b0286823ba97193  bitcoin_0.13.0.orig.tar.gz
2852581d21716b74e0539f7fd2f9c17f5506f1c21c5cec6642b0286823ba97193  v0.13.0.tar.gz

In light of the recent warning on bitcoin.org this feels like a very suboptimal situation.

It seems easy to include additional files in the make dist command (which I guess is what gitian uses to create the tarball that gets signed in SHA256SUMS.asc)

The only problem is maybe that the files under contrib/debian are licensed GPL2/GPL3, see: contrib/debian/copyright.

Here: https://github.com/nomnombtc/bitcoin/commit/1f9c6be4960ddaec6f68c4b4983f94f0ae672a85

is something which creates a new variable DIST_CONTRIB in Makefile.am and adds this to EXTRA_DIST. I included a few useful things like contrib/debian subdir (contains manpages, .desktop file), contrib/rpm subdir (contains .spec file to build rpms), and contrib/init (contains things like systemd startup files) and the *.bash-completion files.

luke-jr commented at 2:20 am on August 24, 2016: member

The two tarballs should be identical except for the addition of generated build scripts (configure, etc) in the release one. IMO you should just submit that commit as a pull request since it improves the situation.

nomnombtc commented at 3:35 am on August 24, 2016: contributor

Okay, here is the PR: #8568

But I agree it would make more sense if they are identical.

laanwj referenced this in commit cf8c4a7633 on Oct 26, 2017

codablock referenced this in commit 07d895e1ca on Sep 26, 2019

codablock referenced this in commit c6c337152f on Sep 30, 2019

barrystyle referenced this in commit 59e55d3bb1 on Jan 22, 2020

laanwj closed this on Mar 25, 2020

sidhujag referenced this in commit 56ca0913fc on Mar 28, 2020

UdjinM6 referenced this in commit 98417ecad2 on Oct 23, 2021

UdjinM6 referenced this in commit 9e85411dc7 on Oct 23, 2021

UdjinM6 referenced this in commit 83cbc3c811 on Dec 4, 2021

DrahtBot locked this on Feb 15, 2022

Release tarball missing many files from git source #6753