net: Disable upnp by default #6795

1. 
   laanwj commented at 6:22 pm on October 9, 2015: member

   Common sentiment is that the miniupnpc codebase likely contains further vulnerabilities (context: #6789).

   I’d prefer to get rid of the dependency completely, but a compromise for now is to at least disable it by default, to prevent UPnP vulnerabilities being a structural danger to the network.

   Also get rid of the confusing --[enable|disable]-upnp-defaultautoconf and define magic.

   Edit: needs backport to 0.11 and 0.10

2. laanwj added the label P2P on Oct 9, 2015
3. laanwj force-pushed on Oct 9, 2015
4. laanwj force-pushed on Oct 9, 2015
5. 
   laanwj commented at 6:27 pm on October 9, 2015: member

   Right, fixed
6. 
   btcdrak commented at 6:35 pm on October 9, 2015: contributor

   utACK
7. 
   luke-jr commented at 6:45 pm on October 9, 2015: member

   NACK removal of configure option; please just change the options gitian uses so people don’t need to hand-patch :(
8. 
   TheBlueMatt commented at 7:08 pm on October 9, 2015: member

   Concept ACK. I’m fine with removing the configure option, not sure we really need it. Its a very different world from when UPnP defaults were set, and I really dont think there is much need for either the GUI or bitcoind to default to UPnP on anymore.
9. net: Disable upnp by default

   Common sentiment is that the miniupnpc codebase likely contains further
   vulnerabilities.
   
   I'd prefer to get rid of the dependency completely, but a compromise for
   now is to at least disable it by default.

   21d27ebad5
10. laanwj force-pushed on Oct 9, 2015
11. laanwj merged this on Oct 10, 2015
12. laanwj closed this on Oct 10, 2015

    ---

13. laanwj referenced this in commit b94ae81576 on Oct 10, 2015
14. laanwj referenced this in commit f2778e0ce6 on Oct 10, 2015
15. laanwj referenced this in commit 4dbcec03ab on Oct 10, 2015
16. laanwj referenced this in commit 460ccfb7b1 on Oct 15, 2015
17. reddink referenced this in commit c4877dbb51 on May 27, 2020
18. MarcoFalke locked this on Sep 8, 2021

Contributors
laanwj btcdrak luke-jr TheBlueMatt

Labels
P2P