limitfreerelay edge case bugfix #6842

pull ptschip wants to merge 1 commits into bitcoin:master from ptschip:limitfreerelay_edgecase changing 1 files +1 −1
  1. ptschip commented at 1:41 AM on October 17, 2015: contributor

    Currently if a new incoming transaction will cause -limitfreerelay to be exceeded then it will still be accepted into the memory pool and the byte counter updated only after the fact.

    What I've been seeing during this attack is that dFreeCount will often get up to 140 to 149KB then the next spam transaction of 15KB will still slip through to bring the total up past the 150KB limit ( limitfreerelay default set at 15), whereas I think it shouldn't be accepted if it's going to exceed the limit. This only allows the attacker to slip through large transactions past the limit, which could be any size up to the transaction size maximum.

  2. ptschip renamed this:
    limitfreerelay edge case bugfix:
    limitfreerelay edge case bugfix
    on Oct 17, 2015
  3. MarcoFalke commented at 11:45 AM on October 17, 2015: member

    Concept ACK but this will create yet another merge conflict with #6349.

  4. laanwj added the label Mempool on Oct 19, 2015
  5. ptschip commented at 3:25 AM on October 21, 2015: contributor

    You're right, #6349 needs to be merged first and then I'll rebase.

  6. ptschip force-pushed on Jan 6, 2016
  7. limitfreerelay edge case bugfix:
    If a new transaction will cause limitfreerelay
    to be exceeded it should not be accepted
    into the memory pool and the byte counter
    should be updated only after the fact.
    2dfeaa1ad0
  8. ptschip force-pushed on Jan 6, 2016
  9. laanwj commented at 11:01 AM on January 28, 2016: member
  10. laanwj added this to the milestone 0.12.0 on Jan 28, 2016
  11. sdaftuar commented at 3:41 PM on January 28, 2016: member

    No strong opinion on this change; since it arguably makes the behavior more intuitive I think it's fine.

    But I think there's no need to include this in 0.12, as this is a pretty small effect, and I'm not sure I'd call the current behavior a "bug" -- just different semantics (bytes allowed now are at the expense of bytes in the future).

  12. laanwj removed this from the milestone 0.12.0 on Jan 28, 2016
  13. laanwj merged this on Jan 29, 2016
  14. laanwj closed this on Jan 29, 2016

  15. laanwj referenced this in commit 019280617a on Jan 29, 2016
  16. ptschip deleted the branch on Mar 7, 2016
  17. codablock referenced this in commit 393d15bf64 on Sep 16, 2017
  18. codablock referenced this in commit 03cbbc8400 on Sep 19, 2017
  19. codablock referenced this in commit ace7eeab34 on Dec 9, 2017
  20. codablock referenced this in commit 9efa4cbef7 on Dec 9, 2017
  21. codablock referenced this in commit c5f84c4e60 on Dec 11, 2017
  22. vecopay referenced this in commit 4286de7409 on Dec 16, 2018
  23. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-24 18:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me