Fix chainstate serialized_size computation #6865

pull sipa wants to merge 1 commits into bitcoin:master from sipa:fixchainsize changing 2 files +2 −2
  1. sipa commented at 9:25 PM on October 21, 2015: member

    This was introduced in #6650 by a cherry-picked commit of mine.

  2. CodeShark commented at 9:57 PM on October 21, 2015: contributor

    ACK

  3. sipa commented at 10:08 PM on October 21, 2015: member

    Seems we have tests that test for the incorrect behaviour?

  4. dcousens commented at 10:18 PM on October 21, 2015: contributor

    ACK

  5. gmaxwell commented at 11:08 PM on October 21, 2015: contributor

    ACK / Tested ACK. Also ... tests are not very meaningful if an effort isn't put in to verify that they're actually testing something. :(

  6. jonasschnelli commented at 8:16 AM on October 22, 2015: contributor

    Tests require an update. https://github.com/bitcoin/bitcoin/blob/master/qa/rpc-tests/blockchain.py#L46 bytes_serialized is no longer 130'000 bytes https://travis-ci.org/bitcoin/bitcoin/jobs/86716075#L4329

  7. gmaxwell commented at 9:04 AM on October 22, 2015: contributor

    It was never 130000 bytes, the test hardcoded an obviously broken value-- not finding the error in the very thing it was testing; thus my complaint above. :(

  8. laanwj commented at 3:40 PM on October 22, 2015: member

    ACK after test fixed

  9. jgarzik commented at 7:28 PM on October 27, 2015: contributor

    ditto @laanwj - ACK after test fixed

  10. Fix chainstate serialized_size computation 298e040bca
  11. sipa force-pushed on Oct 28, 2015
  12. sipa commented at 12:07 AM on October 28, 2015: member

    Test should be fixed, and fix was tested.

  13. gmaxwell merged this on Oct 28, 2015
  14. gmaxwell closed this on Oct 28, 2015
  15. gmaxwell referenced this in commit d0badb916e on Oct 28, 2015
  16. laanwj referenced this in commit 279bde50dc on Oct 31, 2015
  17. laanwj referenced this in commit 8d043126ca on Oct 31, 2015
  18. zkbot referenced this in commit 068e82e00a on Jan 15, 2018
  19. litecoinz-project referenced this in commit 67fb0bf54f on Mar 15, 2018
  20. zkbot referenced this in commit 564119eb31 on Apr 3, 2018
  21. zkbot referenced this in commit 77669b952b on Apr 3, 2018
  22. random-zebra referenced this in commit 73d26f20e9 on May 27, 2020
  23. MarcoFalke locked this on Sep 8, 2021
Contributors
sipaCodeSharkdcousensgmaxwelljonasschnellilaanwjjgarzik
Linked (view graph)
#6650 Obfuscate chainstate#6919 Backport chainstate obfuscation to 0.11
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 18:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me