Restores mempool only BIP113 enforcement #6934

pull gmaxwell wants to merge 2 commits into bitcoin:master from gmaxwell:undo_undo changing 6 files +58 −10

gmaxwell commented at 5:19 PM on November 3, 2015: contributor

This undoes my prior revert to restore BIP113 (MedianTimePast) mempool only.

After careful analysis and testing I determined that the behavior is, in fact, safe-- I and others were just suffering momentary confusion related to locktime semantics.

The block time must be beyond the tx lock time for the transaction to be included. The MTP is already required to be before the blocktime, so using it instead is strictly more strict.

Restore MedianTimePast for locktime.

Revert "Revert "Add rules--presently disabled--for using GetMedianTimePast as endpoint for lock-time calculations""
This reverts commit 40cd32e835092c3158175511da5193193ec54939.

After careful analysis it was determined that the change was, in fact, safe and several people were suffering
momentary confusion about locktime semantics.

e4e5334ef8

Revert "Revert "Enable policy enforcing GetMedianTimePast as the end point of lock-time constraints""
This reverts commit 8537ecdfc40181249ec37556015a99cfae4b21fd.
d1c3762ae8
gmaxwell renamed this:
~~Restores mempool only BIP113 enforces~~
Restores mempool only BIP113 enforcement
on Nov 4, 2015
btcdrak commented at 5:21 AM on November 4, 2015: contributor

utACK
luke-jr commented at 5:34 AM on November 4, 2015: member

Concept ACK
laanwj added the label Mempool on Nov 4, 2015
petertodd commented at 9:32 PM on November 4, 2015: contributor

ACK
sipa commented at 10:01 PM on November 4, 2015: member

ACK
dcousens commented at 12:44 AM on November 5, 2015: contributor

ACK
laanwj merged this on Nov 5, 2015
laanwj closed this on Nov 5, 2015
laanwj referenced this in commit 3038eb63e8 on Nov 5, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels