[qt] Use maxTxFee instead of 10000000 #6951

1. 
   MarcoFalke commented at 6:26 pm on November 5, 2015: member

   @morcos @laanwj @cozz bitcoin-qt should not ignore the param and use DEFAULT_TRANSACTION_MAXFEE = 0.1 * COIN all the time.

   This code behaves exactly the same as the code which got rejected in #6887. (C.f. in-source comment for explanation)

2. [qt] Use maxTxFee instead of 10000000 513686dd43
3. laanwj added the label GUI on Nov 9, 2015
4. laanwj added the label Wallet on Nov 9, 2015
5. 
   laanwj commented at 6:06 am on November 9, 2015: member

   utACK
6. 
   fanquake commented at 7:27 am on November 11, 2015: member

   utACK
7. 
   jonasschnelli commented at 12:15 pm on November 16, 2015: contributor

   Slightly NACK. CreateTransaction() at L277 (https://github.com/bitcoin/bitcoin/blob/master/src/qt/walletmodel.cpp#L277) will already reduce the fee to maxTxFee (through GetMinimumFee(nBytes, nTxConfirmTarget, mempool)). Check: https://github.com/bitcoin/bitcoin/blob/master/src/wallet/wallet.cpp#L2144

   IMO it’s impossible that the changed if triggers (if (nFeeRequired > maxTxFee))).

   I think we should remove the if.

   The only concern I see – is – if a user sets an absurde fee over the QT send coins UI, lets assume 10.0 BTC per kb (which will be accepted in the input filed), the fee will automatically – without warning or informing – reduced to maxTxFee. A warning or information would be appropriate in this case.

8. 
   MarcoFalke commented at 12:17 pm on November 16, 2015: member

   I think we should remove the if. @laanwj did not like that.

9. 
   jonasschnelli commented at 12:21 pm on November 16, 2015: contributor

   After reading the ifs comment, I see the purpose of this check. It’s a “belt-and-suspenders check”. So, it shouldn’t hurt and might protect from insane fees if we once change the wallet layer.

   Changed my mind: Tested ACK.

10. jonasschnelli merged this on Nov 18, 2015
11. jonasschnelli closed this on Nov 18, 2015

    ---

12. jonasschnelli referenced this in commit 03403d8c0f on Nov 18, 2015
13. MarcoFalke deleted the branch on Nov 18, 2015
14. MarcoFalke locked this on Sep 8, 2021

Contributors
MarcoFalke laanwj fanquake jonasschnelli

Labels
GUI Wallet