translations: Don't translate markup or force English grammar #6962

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:MarcoFalke-2015-translations changing 2 files +8 −6

MarcoFalke commented at 12:25 PM on November 6, 2015: member

No description provided.

in src/qt/sendcoinsdialog.cpp:None in 941ce425b4 outdated

 311 | @@ -312,8 +312,9 @@ void SendCoinsDialog::on_sendButton_clicked()
 312 |          if(u != model->getOptionsModel()->getDisplayUnit())
 313 |              alternativeUnits.append(BitcoinUnits::formatHtmlWithUnit(u, totalAmount));
 314 |      }
 315 | -    questionString.append(tr("Total Amount %1<span style='font-size:10pt;font-weight:normal;'><br />(=%2)</span>")
 316 | -        .arg(BitcoinUnits::formatHtmlWithUnit(model->getOptionsModel()->getDisplayUnit(), totalAmount))
 317 | +    questionString.append(tr("Total Amount %1")

laanwj commented at 1:04 PM on November 6, 2015:

Yes, this translation message was really ugly

laanwj commented at 1:05 PM on November 6, 2015: member

utACK
fanquake commented at 1:44 PM on November 7, 2015: member

utACK

in src/init.cpp:None in 941ce425b4 outdated

 498 | @@ -499,6 +499,7 @@ std::string HelpMessage(HelpMessageMode mode)
 499 |  
 500 |  std::string LicenseInfo()
 501 |  {
 502 | +    // todo: remove url's from translations on next change

laanwj commented at 5:25 AM on November 9, 2015:

nit: URLs (no apostrophe)

MarcoFalke commented at 11:00 AM on November 9, 2015:

@laanwj :white_check_mark: fixed nit

laanwj added the label Docs and Output on Nov 9, 2015
translations: Don't translate markdown or force English grammar 6dd3a44ce2
MarcoFalke force-pushed on Nov 9, 2015
laanwj merged this on Nov 9, 2015
laanwj closed this on Nov 9, 2015
laanwj referenced this in commit 6176e9bf3d on Nov 9, 2015
MarcoFalke deleted the branch on Nov 9, 2015
zkbot referenced this in commit 8713d73daf on Dec 18, 2019
zkbot referenced this in commit 2da77edbfe on Dec 18, 2019
zkbot referenced this in commit 577f7ef72a on Dec 18, 2019
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels