Always allow getheaders from whitelisted peers #6974

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2015_11_whitelisted_allow_headers changing 1 files +3 −3

laanwj commented at 1:33 PM on November 9, 2015: member

Process getheaders messages from whitelisted peers even if we are in initial block download. Whitelisted peers can always use a node as a block source.

Also log a debug message when the request is ignored, for troubleshooting.

Addresses #6971.

Always allow getheaders from whitelisted peers

Process `getheaders` messages from whitelisted peers even if we are in
initial block download. Whitelisted peers can always use a node as a
block source.

Also log a debug message when the request is ignored, for
troubleshooting.

Fixes #6971.

40b77d450d

laanwj added the label P2P on Nov 9, 2015
sdaftuar commented at 2:48 PM on November 9, 2015: member

utACK
dcousens commented at 10:13 PM on November 9, 2015: contributor

utACK
gmaxwell commented at 10:37 PM on November 9, 2015: contributor

I think this should also whitelist bypass maxuploadtarget-- for the same reason, no?
jonasschnelli commented at 8:15 AM on November 10, 2015: contributor

@gmaxwell: Agree with a pass for all whitelisted nodes --maxuploadtarget. I think that should be addresses in another PR (which I will open soon).
laanwj merged this on Nov 11, 2015
laanwj closed this on Nov 11, 2015
laanwj referenced this in commit 2f71b07d5e on Nov 11, 2015
luke-jr referenced this in commit 8766acdb0d on Nov 18, 2015
rebroad referenced this in commit 22a4a4fd5c on Nov 2, 2016
rebroad referenced this in commit f5b82fe0bb on Nov 2, 2016
rebroad referenced this in commit f032d43aa0 on Nov 2, 2016
rebroad referenced this in commit 7f68d44c58 on Nov 2, 2016
rebroad referenced this in commit 83d40a910f on Nov 2, 2016
rebroad referenced this in commit cc61ff61ea on Nov 4, 2016
rebroad referenced this in commit e58dcdd7ce on Nov 5, 2016
rebroad referenced this in commit 6c0f1ba60f on Nov 5, 2016
rebroad referenced this in commit 0ec255a812 on Nov 6, 2016
rebroad referenced this in commit 65a43abf3a on Nov 6, 2016
rebroad referenced this in commit ec7fac9a23 on Nov 6, 2016
zkbot referenced this in commit e10008da66 on Feb 18, 2021
zkbot referenced this in commit 777deea264 on Feb 19, 2021
zkbot referenced this in commit b62e35dee8 on Feb 19, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#6971 Is the InitialBlockDownload() check in 'getheaders' too strict?#9061 Ignore getheaders prior to passing all checkpoints.