Globals: Don’t call Params() from miner.cpp #6986

1. 
   jtimon commented at 12:29 pm on November 11, 2015: contributor

   After this, miner.o doesn’t need to ever call Params() anymore. This is part of #5970.

   If #6907 gets merged as well, we can separate Params() [its two versions] and SelectParams() away from chainparams.o (like @theuni wanted to do), maybe to globals/server.o. Then miner needs to include chainparams.h but not globals/server.h (at least while only Params(), Params(std::string) and SelectParams() are exposed there).

2. Chainparams: Explicit CChainParams arg for main (pre miner):

   -ProcessNewBlock
   -TestBlockValidity

   598e494587
3. Chainparams: Explicit CChainParams arg for miner:

   -BitcoinMiner
   -CreateNewBlock
   -GenerateBitcoins
   -ProcessBlockFound

   6bc9e4056b
4. laanwj added the label Refactoring on Nov 11, 2015
5. 
   petertodd commented at 6:09 pm on November 11, 2015: contributor

   utACK
6. 
   dcousens commented at 8:54 pm on November 11, 2015: contributor

   utACK
7. 
   sipa commented at 1:21 am on November 13, 2015: member

   utACK
8. 
   gmaxwell commented at 1:00 am on November 17, 2015: contributor

   ACK.
9. gmaxwell merged this on Nov 17, 2015
10. gmaxwell closed this on Nov 17, 2015

    ---

11. gmaxwell referenced this in commit 87ee0e2dbc on Nov 17, 2015
12. zkbot referenced this in commit 6dcc7dd6ce on Mar 9, 2018
13. zkbot referenced this in commit b094b02c0b on Mar 10, 2018
14. zkbot referenced this in commit 59ef0e4c9c on Mar 12, 2018
15. zkbot referenced this in commit 6dfd4baa1a on Mar 12, 2018
16. zkbot referenced this in commit 05132fdca8 on Apr 6, 2018
17. zkbot referenced this in commit 5fefc451a7 on Apr 13, 2018
18. zkbot referenced this in commit 4c91fbf1c7 on May 31, 2018
19. zkbot referenced this in commit 82d64f57c9 on Oct 24, 2018
20. zkbot referenced this in commit 971f37e510 on Oct 25, 2018
21. zkbot referenced this in commit 5b8b057c96 on Apr 5, 2019
22. zkbot referenced this in commit a53fd12544 on Apr 9, 2019
23. MarkLTZ referenced this in commit a23ef40881 on Apr 27, 2019
24. zkbot referenced this in commit fcf551eaaf on May 24, 2019
25. zkbot referenced this in commit e25cb39033 on May 24, 2019
26. zkbot referenced this in commit 3d37ebe9d8 on May 28, 2019
27. MarcoFalke locked this on Sep 8, 2021

Contributors
jtimon petertodd dcousens sipa gmaxwell

Labels
Refactoring