Fixed integer comparison warning. #7023

pull CodeShark wants to merge 1 commits into bitcoin:master from CodeShark:signed_int_comparison_fix changing 1 files +1 −1

CodeShark commented at 1:13 AM on November 16, 2015: contributor

Explicit typecast to remove compiler warning.
Fixed integer comparison warning. 4d29032a64
in src/main.cpp:None in 4d29032a64
```
2576 | @@ -2577,7 +2577,7 @@ bool FindBlockPos(CValidationState &state, CDiskBlockPos &pos, unsigned int nAdd
2577 |          pos.nPos = vinfoBlockFile[nFile].nSize;
2578 |      }
2579 |  
2580 | -    if (nFile != nLastBlockFile) {
```
dcousens commented at 1:32 AM on November 16, 2015:

This is obviously the smaller change, but, couldn't nLastBlockFile just be unsigned?

CodeShark commented at 1:41 AM on November 16, 2015:

I think it could - but that would require having to check whether that breaks anything...and if we're going down that route, we could also start changing a bunch of other variables...and I don't think I want to go down that path right now :)
laanwj commented at 8:47 AM on November 16, 2015: member

ACK. I don't think nLastBlockFile can be usefully negative, but this is clearly the least risky change.
laanwj added the label Refactoring on Nov 16, 2015
paveljanik commented at 8:56 AM on November 16, 2015: contributor

ACK

The warning comes from #6948.
gmaxwell commented at 12:35 AM on November 17, 2015: contributor

ACK.
gmaxwell merged this on Nov 17, 2015
gmaxwell closed this on Nov 17, 2015
gmaxwell referenced this in commit 0a547d2d55 on Nov 17, 2015
luke-jr referenced this in commit 9596888340 on Nov 18, 2015
luke-jr referenced this in commit 37ac133328 on Dec 8, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels