[doc][trivial] Remove miniupnpc build notes from build-unix #7048

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:miniupnpc-build-unix changing 1 files +0 −8

fanquake commented at 12:57 AM on November 18, 2015: member

Users shouldn’t have the impression that we’re using/constrained to an older version of miniupnpc, so update the doc to the latest version.

[skip-ci]
laanwj commented at 7:51 AM on November 18, 2015: member

Probably we shouldn't mention a version at all there - goes out of date too soon, especially with miniupnp :-)
laanwj added the label Docs and Output on Nov 18, 2015
fanquake force-pushed on Nov 18, 2015
fanquake commented at 10:02 AM on November 18, 2015: member

@laanwj I've removed the version number.
MarcoFalke commented at 10:32 AM on November 18, 2015: member

utACK 7ce56ab
in doc/build-unix.md:None in 7ce56ab469 outdated
```
 141 | -	cd miniupnpc-1.6
 142 | +	tar -xzvf miniupnpc-x.x.tar.gz
 143 | +	cd miniupnpc-x.x
 144 |  	make
 145 |  	sudo su
 146 |  	make install
```
jonasschnelli commented at 1:31 PM on November 18, 2015:

another change could be: sudo make install?

laanwj commented at 3:15 PM on November 18, 2015:

Hmm, thinking about it, I don't like recommending installing it globally at all E.g. the berkeleydb build instructions describe how to install to a local dir and use it there
laanwj commented at 3:16 PM on November 18, 2015: member
Taking a step back here:
- Why do we need specific instructions about building upnp at all? Those should be documented by the miniupnp project.
- Using upnp isn't encouraged...
- People that build from source generally know how to set up port forwardings.
My new proposal: let's remove this section. Optionally replace with a pointer to the miniupnpc docs.
paveljanik commented at 7:50 PM on November 18, 2015: contributor

I agree with Wladimir (the main reason for me is the second one).
[doc][trivial] Remove miniupnpc build notes build-unix c5f211bbd0
fanquake force-pushed on Nov 19, 2015
fanquake commented at 1:35 AM on November 19, 2015: member

Updated to remove the build instructions entirely.
fanquake renamed this:
~~[doc][trivial] Update miniupnpc version in build-unix~~
[doc][trivial] Remove miniupnpc build notes from build-unix
on Nov 19, 2015
jmcorgan commented at 3:19 AM on November 19, 2015: contributor

utACK
dcousens commented at 3:24 AM on November 19, 2015: contributor

utACK
jonasschnelli commented at 7:06 AM on November 19, 2015: contributor

ACK
paveljanik commented at 8:13 AM on November 19, 2015: contributor

ACK
laanwj merged this on Nov 19, 2015
laanwj closed this on Nov 19, 2015
laanwj referenced this in commit f8e87d74c9 on Nov 19, 2015
luke-jr referenced this in commit 702ed196d6 on Jan 10, 2016
luke-jr referenced this in commit 6821639c4b on Jan 10, 2016
fanquake deleted the branch on May 12, 2016
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels