ui: Add "Copy raw transaction data" to transaction list context menu #7051

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2015_11_transaction_hex2 changing 4 files +26 −0

laanwj commented at 8:10 AM on November 18, 2015: member

Add a way to quickly copy transaction hex to clipboard.

Primarily useful when manually submitting transactions, e.g. -walletbroadcast=0 is set.
laanwj added the label GUI on Nov 18, 2015
MarcoFalke commented at 8:11 AM on November 18, 2015: member

Concept ACK

in src/qt/transactionview.cpp:None in a3d90260e3 outdated

 140 | @@ -141,6 +141,7 @@ TransactionView::TransactionView(const PlatformStyle *platformStyle, QWidget *pa
 141 |      QAction *copyLabelAction = new QAction(tr("Copy label"), this);
 142 |      QAction *copyAmountAction = new QAction(tr("Copy amount"), this);
 143 |      QAction *copyTxIDAction = new QAction(tr("Copy transaction ID"), this);
 144 | +    QAction *copyTxHexAction = new QAction(tr("Copy raw transaction data"), this);

MarcoFalke commented at 8:13 AM on November 18, 2015:

Nit: You could get rid of the "data" suffix because "raw transaction" already implies this.

laanwj commented at 8:18 AM on November 18, 2015:

Sounds good to me. Did decide not to use hex as that will give translation issues :-)

jonasschnelli commented at 8:16 AM on November 18, 2015: contributor

Nice! utACK. Will test soon.
gmaxwell commented at 8:21 AM on November 18, 2015: contributor

Neat. Concept ACK.
jonasschnelli commented at 1:23 PM on November 18, 2015: contributor
Tested ACK.

<img width="1146" alt="bildschirmfoto 2015-11-18 um 14 20 37" src="https://cloud.githubusercontent.com/assets/178464/11242046/926c2a08-8dff-11e5-8270-7456feed33c4.png">

One little thing (not related to this PR):
- If you select multiple rows in the table and use the context menu, it does affect the column at the very top of the selection (even if you open the context menu "over" another row). I think we should disallow multiple row-selection.
paveljanik commented at 8:34 PM on November 18, 2015: contributor

I like it!

ACK (please remove the "data").
laanwj force-pushed on Nov 19, 2015

ui: Add "Copy raw transaction data" to transaction list context menu

Add a way to quickly copy transaction hex.

Primarily useful when manually submitting transactions,
e.g. `-walletbroadcast=0` is set.

b4f3e9c09e

MarcoFalke commented at 11:24 AM on November 19, 2015: member

utACK b4f3e9c
laanwj merged this on Nov 19, 2015
laanwj closed this on Nov 19, 2015
laanwj referenced this in commit a1907772f0 on Nov 19, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels