MiB should be MB.
Length is computed in MB but text is saying it's MiB
/\ Maximum length of incoming protocol messages (no message over 2 MiB is currently acceptable). / static const unsigned int MAX_PROTOCOL_MESSAGE_LENGTH = 2 \ 1024 * 1024;
MAX_PROTOCOL_MESSAGE_LENGTH description #7055
pull ptschip wants to merge 1 commits into bitcoin:master from ptschip:maxmessage changing 1 files +1 −1-
ptschip commented at 2:57 PM on November 18, 2015: contributor
-
a2683ea210
MAX_PROTOCOL_MESSAGE_LENGTH description
MiB should be MB
-
sipa commented at 3:01 PM on November 18, 2015: member
I don't understand; it looks exactly right as it was?
-
MarcoFalke commented at 3:14 PM on November 18, 2015: member
NACK. You are not wrong because #6979 (review) but I don't think we should bike shed about that in comments.
What is more needed, is to transform the
-maxuploadstuff to MB (1e6 byte) instead of using MiB? -
ptschip commented at 3:40 PM on November 18, 2015: contributor
2MiB is 2000000, not 2 * 1024 * 1024...
On 18/11/2015 7:02 AM, Pieter Wuille wrote:
I don't understand; it looks exactly right as it was?
— Reply to this email directly or view it on GitHub #7055 (comment).
-
MarcoFalke commented at 3:43 PM on November 18, 2015: member
-
ptschip commented at 3:44 PM on November 18, 2015: contributor
ok, never mind..i'll close...i'm from the old school.
On 18/11/2015 7:15 AM, MarcoFalke wrote:
NACK. You are not wrong because #6979 (comment) #6979 (review) but I don't think we should bike shed about that in comments.
What is more needed, is to transform the |-maxupload| stuff to MB (1e6 byte) instead of using MiB?
— Reply to this email directly or view it on GitHub #7055 (comment).
-
ptschip commented at 3:44 PM on November 18, 2015: contributor
closing..
I'll never get used to MiB
- ptschip closed this on Nov 18, 2015
- ptschip deleted the branch on Apr 5, 2016
- DrahtBot locked this on Sep 8, 2021
Contributors