[Trivial] Move time data log print to 'net' category to reduce noise #7075

pull tulip0 wants to merge 1 commits into bitcoin:master from tulip0:no-time-offset-logging changing 1 files +7 −7

tulip0 commented at 6:57 AM on November 22, 2015: none

On every peer connection Bitcoin Core prints timestamp offset information to the main log, this adds noise and has little utility. This patch moves it to the "net" debug category instead.
Move time data log print to 'net' category to reduce log noise 4846543ac5
tulip0 renamed this:
~~Move time data log print to 'net' category to reduce noise~~
[Trivial] Move time data log print to 'net' category to reduce noise
on Nov 22, 2015
gmaxwell commented at 10:03 PM on November 22, 2015: contributor

utACK
in src/timedata.cpp:None in 4846543ac5
```
 112 | -        }
 113 | -        LogPrintf("nTimeOffset = %+d  (%+d minutes)\n", nTimeOffset, nTimeOffset/60);
 114 | +        
 115 | +        BOOST_FOREACH(int64_t n, vSorted)
 116 | +            LogPrint("net", "%+d  ", n);
 117 | +        LogPrint("net", "|  ");
```
MarcoFalke commented at 7:52 AM on November 23, 2015:

Will this look weird when we decide to auto print the category?
tulip0 commented at 8:15 AM on November 23, 2015:

Yes, it'll need fixing if that change is made in the future. Does anybody run in the non-specific -debug mode that would require this?

2015-11-23 08:06:14 Added time data, samples 5, offset -1 (+0 minutes) 2015-11-23 08:06:14 -1 -1 -1 +0 +0 | nTimeOffset = -1 (+0 minutes)

Maybe that second print can go away entirely? The utility for debugging seems low.
laanwj commented at 9:01 AM on November 24, 2015:

Will this look weird when we decide to auto print the category?

Not if we stick with a strict format, and only print the category name on new lines along with the time. Outputting something using multiple PrintX calls has always been possible, and should still be possible after that (currently purely theoretical) change.
laanwj commented at 9:02 AM on November 24, 2015: member

Good idea, utACK
laanwj merged this on Nov 24, 2015
laanwj closed this on Nov 24, 2015
laanwj referenced this in commit b19fe277dd on Nov 24, 2015
tulip0 deleted the branch on Nov 29, 2015
zkbot referenced this in commit e10008da66 on Feb 18, 2021
zkbot referenced this in commit 777deea264 on Feb 19, 2021
zkbot referenced this in commit b62e35dee8 on Feb 19, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors