[Trivial, Doc] Describe maxmempool and mempoolminfee in the getmempoolinfo RPC help. #7118

pull paveljanik wants to merge 1 commits into bitcoin:master from paveljanik:20151127_getmempoolinfo_fixes changing 1 files +5 −3

paveljanik commented at 3:59 PM on November 27, 2015: contributor

Add missing documentation to the getmempoolinfo RPC call.

What about mexmempool -> max, mempoolminfee -> minfee?
jonasschnelli added the label RPC on Nov 28, 2015
paveljanik renamed this:
~~Describe maxmempool and mempoolminfee in the getmempoolinfo RPC help.~~
[Trivial, Doc] Describe maxmempool and mempoolminfee in the getmempoolinfo RPC help.
on Nov 28, 2015
sipa commented at 12:01 PM on November 28, 2015: member

utACK
pstratem commented at 10:06 AM on November 29, 2015: contributor

unACK
Describe maxmempool and mempoolminfee in the getmempoolinfo RPC help. b212f94dd9
in src/rpcblockchain.cpp:None in a0ff352046 outdated
```
 797 | @@ -798,6 +798,8 @@ UniValue getmempoolinfo(const UniValue& params, bool fHelp)
 798 |              "  \"size\": xxxxx                (numeric) Current tx count\n"
 799 |              "  \"bytes\": xxxxx               (numeric) Sum of all tx sizes\n"
 800 |              "  \"usage\": xxxxx               (numeric) Total memory usage for the mempool\n"
 801 | +            "  \"maxmempool\": xxxxx          (numeric) Maximum memory usage for the mempool\n"
```
laanwj commented at 10:08 AM on December 1, 2015:

Nit: all the other RPC helps have commas after all but the last field in an object, to make it look more like actual JSON:

" \"usage\": xxxxx, " \"maxmempool\": xxxxx, " \"mempoolminfee\": xxxxx

Not that I care deeply about this (or at all, really), but you may preempt someone that wants to make that update later :)
paveljanik commented at 10:16 AM on December 1, 2015:

I can add the commas in the other lines as well (wanted to minimize changes).

laanwj commented at 10:17 AM on December 1, 2015:

Sure, let's do that. Better to do this (update the help for getmempoolinfo) in one go.
paveljanik force-pushed on Dec 1, 2015
fanquake commented at 8:13 AM on December 2, 2015: member

utACK
laanwj merged this on Dec 2, 2015
laanwj closed this on Dec 2, 2015
laanwj referenced this in commit 8e598dc4ea on Dec 2, 2015
DrahtBot locked this on Sep 8, 2021

Contributors

Labels