Travis: Test build against system libs (& Qt4) #7142

pull luke-jr wants to merge 2 commits into bitcoin:master from luke-jr:travis_qt4 changing 1 files +9 −5
  1. luke-jr commented at 10:46 AM on December 1, 2015: member

    Also removes now-unnecessary bc dependency from other builds.

  2. laanwj added the label Build system on Dec 1, 2015
  3. laanwj added the label Tests on Dec 1, 2015
  4. laanwj commented at 11:30 AM on December 1, 2015: member

    Concept ACK on testing with qt4, but I'm not entirely happy about adding yet another build for this, Travis is slow enough these days.

  5. jonasschnelli commented at 11:57 AM on December 1, 2015: contributor

    Concept ACK. Agree with @laanw but IMO another build is more valuable then a speedy CI.

  6. laanwj commented at 12:01 PM on December 1, 2015: member

    @jonasschnelli I wonder if there's a compromise, if we can combine the qt4 build with one of the existing builds

  7. jonasschnelli commented at 12:24 PM on December 1, 2015: contributor

    We only have one linux "full" Qt5 build "32bit + dash". The other linux QT5 build does not build the wallet. Maybe it would be worth to change one of the windows builds (Win32) to build with Qt4? On the other hand, Qt4 mostly makes sense on Linux, but even though, a Win32 Qt4 build should at least detect most Qt4 incompatibilities.

  8. laanwj commented at 12:29 PM on December 1, 2015: member

    Yeah. That may work. Anyhow this is up to @theuni. Another option would be to combine this build with something else that we wanted to test already, so that it's not just added for qt4.

  9. luke-jr force-pushed on Dec 1, 2015
  10. luke-jr force-pushed on Dec 1, 2015
  11. luke-jr force-pushed on Dec 1, 2015
  12. luke-jr force-pushed on Dec 2, 2015
  13. luke-jr force-pushed on Dec 2, 2015
  14. luke-jr commented at 3:07 AM on December 2, 2015: member

    @theuni Can't seem to get this to build with Qt - any ideas? Shouldn't --with-qt=qt4 configure fail if it has a problem? :/

  15. luke-jr commented at 6:24 AM on December 2, 2015: member

    @laanwj Oh, an idea if Travis time is a concern: make this build use only system libraries (no depends). That's probably better test coverage anyway...

  16. laanwj commented at 9:24 AM on December 2, 2015: member

    @laanwj Oh, an idea if Travis time is a concern: make this build use only system libraries (no depends). That's probably better test coverage anyway...

    Not a bad idea because of the extra test coverage with old libraries, but I don't think that will save much time as the depends are supposed to be built once and cached anyway.

  17. MarcoFalke commented at 10:43 AM on December 2, 2015: member

    supposed to be built once and cached anyway.

    Does travis cache between builds, I don't think so?

  18. laanwj commented at 11:25 AM on December 2, 2015: member

    No, not between builds, I think. In most cases this would make no sense as they have different flags or even a different platform.

  19. theuni commented at 6:20 PM on December 2, 2015: member

    Right. To clarify, depends are cached and re-used for subsequent builds of the same config. Each config is an island though.

    Personally, I don't think this is worth adding another build for. If anything, I'd rather do as @laanwj said and combine it with another.

  20. laanwj commented at 2:48 PM on December 3, 2015: member

    Travis PR test is quite slow lately. I'd certainly prefer not to add another config.

    Testing more obscure platforms and library versions (like Qt4) may be better suited for something like a nightly extended build (e.g. #7148)

  21. luke-jr commented at 11:43 PM on January 13, 2016: member

    Once #7339 is merged, I suggest this can be extended to test --without-libevent as well.

  22. laanwj commented at 10:03 AM on January 16, 2016: member

    Closing, this is part of #7148 now

  23. laanwj closed this on Jan 16, 2016
  24. laanwj reopened this on May 25, 2017
  25. laanwj commented at 11:28 AM on June 24, 2017: member

    Needs rebase.

  26. jtimon commented at 11:06 PM on June 24, 2017: contributor

    Concept ACK

  27. luke-jr force-pushed on Jul 5, 2017
  28. luke-jr commented at 8:34 AM on July 5, 2017: member

    Rebased, sorry for the delay

  29. TheBlueMatt commented at 5:43 PM on July 11, 2017: member

    Concept ACK. Only concern is are we willing to add more jobs to travis? Can we pay them to make things go faster?

  30. MarcoFalke commented at 10:54 AM on July 30, 2017: member

    @TheBlueMatt According to apache, it is possible to increase the number of concurrent builds. (https://blogs.apache.org/infra/entry/apache_gains_additional_travis_ci)

    Though, I am slightly worried that this makes it harder for developers to fork the project and enable travis on their fork. After switching to the paid infrastructure, we might have faster machines or even extended timeouts for the build times. By forking the project, the new limits no longer apply and builds might time out or fail, which is a nuisance for new contributors.

  31. MarcoFalke commented at 10:56 AM on July 30, 2017: member

    Is this still WIP or ready for review?

  32. in .travis.yml:29 in ab1cacfc66 outdated 
      24 | @@ -25,6 +25,8 @@ env:
  25 |      - HOST=arm-linux-gnueabihf PACKAGES="g++-arm-linux-gnueabihf" DEP_OPTS="NO_QT=1" CHECK_DOC=1 GOAL="install" BITCOIN_CONFIG="--enable-glibc-back-compat --enable-reduce-exports"
  26 |  # Win32
  27 |      - HOST=i686-w64-mingw32 DPKG_ADD_ARCH="i386" DEP_OPTS="NO_QT=1" PACKAGES="python3 nsis g++-mingw-w64-i686 wine1.6 bc" RUN_TESTS=true GOAL="install" BITCOIN_CONFIG="--enable-reduce-exports"
  28 | +# Qt4
  29 | +    - HOST=x86_64-unknown-linux-gnu PACKAGES="bc python3-zmq qt4-dev-tools" DEP_OPTS="NO_QT=1" RUN_TESTS=true GOAL="install" BITCOIN_CONFIG="--enable-zmq --enable-glibc-back-compat --enable-reduce-exports --with-qt=qt4 CPPFLAGS=-DDEBUG_LOCKORDER"
    MarcoFalke commented at 1:20 PM on July 30, 2017:

    No need for the bc package. Also, the configure option is called --with-gui=qt4.

    luke-jr commented at 6:13 PM on August 4, 2017:

    Why is bc not needed here? Other builds need it...?

    MarcoFalke commented at 11:21 PM on August 4, 2017:

    I can't figure out why the "GNU bc arbitrary precision calculator language" is required. It is likely an artifact of the days where the functional tests were written in bash.

  33. luke-jr renamed this:
    [WIP] Travis: Test build against system Qt4
    Travis: Test build against system Qt4
    on Jul 30, 2017
  34. luke-jr force-pushed on Aug 5, 2017
  35. luke-jr force-pushed on Aug 5, 2017
  36. luke-jr commented at 9:53 AM on August 5, 2017: member

    Fixed issues, rebased, and removed bc from the other builds too.

  37. luke-jr force-pushed on Aug 5, 2017
  38. Travis: Remove bc tool from dependencies 8d82e1336a
  39. Travis: Test build against system libs (& Qt4) 6d2aac8bb1
  40. luke-jr force-pushed on Aug 5, 2017
  41. luke-jr renamed this:
    Travis: Test build against system Qt4
    Travis: Test build against system libs (& Qt4)
    on Aug 5, 2017
  42. luke-jr commented at 11:57 AM on August 5, 2017: member

    There, tests pass now, and it tests against more system dependencies as well.

  43. MarcoFalke commented at 9:53 PM on August 8, 2017: member

    utACK 6d2aac8bb142adc1e5cff9dd91ddd1d91403b33c

  44. MarcoFalke merged this on Sep 12, 2017
  45. MarcoFalke closed this on Sep 12, 2017
  46. MarcoFalke referenced this in commit 801dd40666 on Sep 12, 2017
  47. MarcoFalke locked this on Sep 8, 2021
Contributors
luke-jrlaanwjjonasschnelliMarcoFalketheunijtimonTheBlueMatt
Labels
Build systemTests
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-15 15:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me