Bugfix: Correctly calculate priority when inputs are mined after dependent transactions enter the memory pool #7149

1. 
   luke-jr commented at 9:42 pm on December 1, 2015: member

   This is needed to restore proper CreateNewBlock functioning for unconfirmed transaction chains.
2. jonasschnelli added the label TX fees and policy on Dec 2, 2015
3. luke-jr force-pushed on Jan 13, 2016
4. 
   luke-jr commented at 9:38 pm on January 13, 2016: member

   Added RPC tests and fixed an additional bug found with them. This should now be ready for merging to master and 0.12.
5. 
   sipa commented at 8:22 pm on June 2, 2016: member

   Weak concept NACK. I don’t think we should be spending effort on maintaining the old priority system (which was completely arbirary anyway).
6. luke-jr referenced this in commit fbe78b25a6 on Jun 9, 2016
7. luke-jr referenced this in commit eb27ab182b on Jun 26, 2016
8. luke-jr referenced this in commit cf9b330a54 on Jun 27, 2016
9. Add GetStartingPriority method to reliably get the original priority of a transaction in the mempool c6c89bb163
10. Change GetPriority calculation to dynamically update

    Track the value of inputs that get confirmed in the chain and keep a cached value of priority at a given height and return current priority by only assuming these in chain inputs are aging.

    8aa1ae2242
11. Add consistency check for on the fly priority calculations 98ef48370c
12. QA: Add test for priority via getrawmempool 2d7288858f
13. QA: Enable testing priority via getblocktemplate as well cc260ed801
14. QA: Extend txn_priority test to check across a reorganisation 6704f5b434
15. Bugfix: Correct off-by-one errors in getrawmempool startingpriority and currentpriority

    - Since the transaction arrives after block N, its starting priority is that for block N+1.
    - The current priority is likewise as considered for mining the next block.

    92c18a4634
16. Bugfix: rpc-tests/txn_priority: When connecting disconnected nodes, their mempools may not sync, so only sync blocks fab562bd26
17. CTxMemPool::check: Use height+1 for priority comparison, since height is not guaranteed to work ae93a95510
18. luke-jr force-pushed on Nov 16, 2016
19. 
    fanquake commented at 1:23 pm on January 12, 2017: member

    Closing this due to inactivity.
20. fanquake closed this on Jan 12, 2017

    ---

21. MarcoFalke locked this on Sep 8, 2021

Contributors
luke-jr sipa fanquake

Labels
TX fees and policy