... by sending the correct codebase name of Satoshi and, if PUBLIC_CLIENT_NAME is defined, the front-end name after that
Bugfix: comply with BIP 0014 ... #715
pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:bugfix_client_name changing 9 files +63 −21-
luke-jr commented at 8:57 PM on December 19, 2011: member
-
gavinandresen commented at 8:59 PM on December 19, 2011: contributor
NACK.
-
luke-jr commented at 9:57 PM on December 19, 2011: member
I love nonsensical NACKs. Especially on bugfixes.
-
gavinandresen commented at 10:42 PM on December 19, 2011: contributor
All right, NACK: adds 40 lines of code and a bunch of confusing #ifdefs for no good reason.
-
luke-jr commented at 10:46 PM on December 19, 2011: member
Adds 40 lines of code for complying with the community standard everyone accepted...
-
TheBlueMatt commented at 1:20 AM on December 20, 2011: member
Complying with the standards as you read it (I dont read it that way, but whatever) doesnt take 40 lines anyway.
-
luke-jr commented at 9:50 PM on January 11, 2012: member
Indeed, it could be done in fewer if we had an unanimous consensus whether there should be a difference between how bitcoind and Bitcoin-Qt advertise themselves. But making it configurable so both camps can be happy does take slightly more code.
-
Bugfix: comply with BIP 0014 by sending the correct codebase name of Satoshi and, if PUBLIC_CLIENT_NAME is defined, the front-end name after that 0590bd249e
-
jgarzik commented at 10:25 PM on February 3, 2012: contributor
NAK also. Current client has been out there with current behavior, making the new standard not as widely accepted as implied. There are also disagreements over how one reads the standard.
- jgarzik closed this on Feb 3, 2012
-
luke-jr commented at 10:47 PM on February 3, 2012: member
There is no current released client out there with the broken behaviour. Please merge this fix or reopen...
-
sipa commented at 2:09 PM on February 22, 2012: member
This patch seems to change several things at once, but at least one is very reasonable imho, namely the fact that bitcoind now advertizes itself as Bitcoin-qt. A much simpler patch would allow fixing that.
-
sipa commented at 3:26 PM on February 22, 2012: member
Actually, what about just changing the version string to "/Satoshi:0.6.0/" ?
- destenson referenced this in commit c40fccce9a on Jun 26, 2016
- destenson referenced this in commit 31ff9c2ff8 on Jun 26, 2016
- ptschip referenced this in commit 0fe396502f on Aug 2, 2017
- dexX7 referenced this in commit 82865262a3 on Aug 8, 2018
- Losangelosgenetics referenced this in commit 8edd0078a2 on Mar 12, 2020
- rajarshimaitra referenced this in commit 6c7d337ae9 on Aug 5, 2021
- DrahtBot locked this on Sep 8, 2021
