[RPC] getblock: Added help text for chainwork value #7232

1. 
   instagibbs commented at 7:09 pm on December 18, 2015: member

   I took the text from bitcoin.org’s description. @harding Is this originally from there?

   edit: Changed the wording

2. instagibbs renamed this:
   Added help text for chainwork value
   [RPC] Added help text for chainwork value
   on Dec 18, 2015
3. 
   harding commented at 9:58 pm on December 18, 2015: contributor

   @instagibbs yes; that description was written by me based upon my reading of the code.
4. jonasschnelli added the label Docs and Output on Dec 19, 2015
5. 
   fanquake commented at 0:43 am on December 24, 2015: member

   ACK
6. instagibbs renamed this:
   [RPC] Added help text for chainwork value
   [RPC] getblock: Added help text for chainwork value
   on Jan 4, 2016
7. in src/rpcblockchain.cpp: in 631cfe7758 outdated

   383@@ -384,6 +384,7 @@ UniValue getblock(const UniValue& params, bool fHelp)
   384             "  \"nonce\" : n,           (numeric) The nonce\n"
   385             "  \"bits\" : \"1d00ffff\", (string) The bits\n"
   386             "  \"difficulty\" : x.xxx,  (numeric) The difficulty\n"
   387+            "  \"chainwork\" : \"xxxx\",  (string) The estimated number of block header hashes checked from the genesis block to this block, in hexadecimal\n"
   

   ---

   ---

   

   MarcoFalke commented at 6:39 pm on January 4, 2016:

   I don’t understand this sentence. I like (string) Expected number of hashes required to produce the current chain (in hex) better.

   ---

   

   instagibbs commented at 7:25 pm on January 4, 2016:

   What don’t you understand about it specifically? Would:

   (string) Expected number of hashes required to produce the chain up to this block (in hex)

   be better? As-is it’s ambiguous to what “current chain” means. In getblockchaininfo it clearly means the valid chain with most work.

   ---

   

   MarcoFalke commented at 8:48 pm on January 4, 2016:

   block header hashes

   is not immediately clear what this means. Usually blocks with hashes that don’t hit the diff are not considered valid, so they are not counted. Then “estimated” gives the hint that they are counted as well.

   ---

   

   MarcoFalke commented at 8:49 pm on January 4, 2016:

   @instagibbs I like your suggestion as well.
8. 
   instagibbs commented at 4:42 pm on January 11, 2016: member

   Updated wording re: @MarcoFalke comments.
9. Added help text for chainwork value 94bdd71f9b
10. instagibbs force-pushed on Jan 11, 2016
11. 
    MarcoFalke commented at 6:05 pm on January 11, 2016: member

    utACK 94bdd71f9b4768c9803ffd133aa7781b19bfa6f9
12. laanwj merged this on Jan 18, 2016
13. laanwj closed this on Jan 18, 2016

    ---

14. laanwj referenced this in commit ae20172941 on Jan 18, 2016
15. laanwj referenced this in commit c0d2382170 on Jan 18, 2016
16. 
    laanwj commented at 11:21 am on January 18, 2016: member

    utACK
17. MarcoFalke locked this on Sep 8, 2021

Contributors
instagibbs harding fanquake MarcoFalke laanwj

Labels
Docs