[gitian] Default reference date to commit author date #7252

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:MarcoFalke-2015-gitianTime-0.13 changing 5 files +0 −5

MarcoFalke commented at 11:36 AM on December 25, 2015: member

<strike>Parallel to #7251 as 0.13 is released 2016-07-01?
fanquake commented at 12:42 PM on December 25, 2015: member

I'm not sure we want to start making file changes in anticipation of events 6 months ahead. This also means that any gitian builds of master between this merging and the 2016-07 are from the future? :watch:

Other than being the 'real' date, what value does changing these add. I'm assuming the dates are already new enough that the binary file views isn't an issue?
luke-jr commented at 12:52 PM on December 25, 2015: member

Maybe we can get gitian to pull it from the git commit date?
MarcoFalke commented at 12:57 PM on December 25, 2015: member

@fanquake I will add this to release-process.md, so @laanwj can do it before every release. @luke-jr I'd prefer this option as well...
MarcoFalke commented at 12:46 PM on December 26, 2015: member

https://github.com/devrandom/gitian-builder/pull/113
MarcoFalke force-pushed on Dec 27, 2015
jonasschnelli commented at 7:24 PM on December 27, 2015: contributor

Agree with @luke-jr: can we not load the date from the tag/commit date? Time could set be set to 00:00.
jonasschnelli added the label Build system on Dec 27, 2015
MarcoFalke commented at 7:34 PM on December 27, 2015: member

Time could set be set to 00:00

No need to fiddle with the time. Imo it makes sense to have the exact commit (author) date corresponding to the commit which is shown in the debug window.
MarcoFalke renamed this:
~~[gitian] Set reference date to actual release date~~
[gitian] Default reference date to commit author date
on Dec 28, 2015
[gitian] Default reference_datetime to commit author date fa7b04c68a
MarcoFalke force-pushed on Jan 2, 2016
MarcoFalke commented at 2:17 PM on January 2, 2016: member

@jonasschnelli Would be nice to see if this works on your build box. Make sure to update gitian-builder, first.
laanwj commented at 8:45 AM on January 4, 2016: member

@fanquake I will add this to release-process.md, so @laanwj can do it before every release.

If you do this, please automate it (you can find the commit timestamp using some git command?), it's not worth adding another manual step to me.
MarcoFalke commented at 10:18 AM on January 4, 2016: member

Needs rebase. Closing for now and making it a new pull.
MarcoFalke closed this on Jan 4, 2016
MarcoFalke deleted the branch on Jan 4, 2016
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#7251 [0.12] gitian: Set reference date to something more recent