[init] Add missing help for args #7290

pull MarcoFalke wants to merge 4 commits into bitcoin:master from MarcoFalke:Mf1601-doc changing 1 files +10 −2
  1. MarcoFalke commented at 5:38 pm on January 4, 2016: member
  2. MarcoFalke force-pushed on Jan 4, 2016
  3. MarcoFalke commented at 5:54 pm on January 4, 2016: member

    This also includes a bugfix:

    screenshot from 2016-01-04 18-53-38 screenshot from 2016-01-04 18-53-22

  4. jonasschnelli commented at 7:39 pm on January 4, 2016: contributor
    utACK. Nice catch (missing uacomment and maptxfee)!
  5. jonasschnelli added the label Docs and Output on Jan 4, 2016
  6. fanquake commented at 10:33 pm on January 4, 2016: member

    utACK

    On Tuesday, 5 January 2016, Jonas Schnelli notifications@github.com wrote:

    utACK. Nice catch (missing uacomment and maptxfee)!

    — Reply to this email directly or view it on GitHub #7290 (comment).

  7. laanwj commented at 10:31 am on January 7, 2016: member
    Needs rebase after #7257
  8. [init] Fix error message of maxtxfee invalid amount fac11ea310
  9. [init] Add missing help for args fa6ab96799
  10. [init] Help Msg: Use Params(CBaseChainParams::MAIN) faa572a329
  11. MarcoFalke force-pushed on Jan 7, 2016
  12. MarcoFalke commented at 11:37 am on January 7, 2016: member
    Rebased.
  13. in src/init.cpp: in faa572a329 outdated
    458@@ -453,6 +459,7 @@ std::string HelpMessage(HelpMessageMode mode)
    459     if (showDebug)
    460     {
    461         strUsage += HelpMessageOpt("-logtimemicros", strprintf("Add microsecond precision to debug timestamps (default: %u)", DEFAULT_LOGTIMEMICROS));
    462+        strUsage += HelpMessageOpt("-mocktime=<n>", "Replace actual time with <n> (default: 0)");
    


    paveljanik commented at 11:08 am on January 9, 2016:

    As -mocktime=0 is a no op, I’d remove the default. What about this:

    0Replace actual time with <n> seconds since epoch
    

    MarcoFalke commented at 1:00 pm on January 9, 2016:

    It’s a developer documentation and I think it’s useful to know that 0 means noop.

    Though, I am using your extended description.

  14. paveljanik commented at 11:08 am on January 9, 2016: contributor
    But ACK anyway.
  15. Clarify mocktime help message fa461df685
  16. MarcoFalke commented at 7:42 pm on January 14, 2016: member
    @laanwj Anything holding this back? (Some of this actually should go into 0.12.0, I can prepare the backport after you did the merge)
  17. jonasschnelli commented at 7:43 pm on January 14, 2016: contributor
    rc1 has be detached. I guess only important bugfixes should go into 0.12 now. But Re-ACK for master.
  18. laanwj merged this on Jan 18, 2016
  19. laanwj closed this on Jan 18, 2016

  20. laanwj referenced this in commit c851d8d71b on Jan 18, 2016
  21. MarcoFalke deleted the branch on Jan 18, 2016
  22. MarcoFalke referenced this in commit 44438a192a on Jan 18, 2016
  23. MarcoFalke referenced this in commit 236686b844 on Jan 18, 2016
  24. codablock referenced this in commit 7d8d8bb9f8 on Sep 16, 2017
  25. codablock referenced this in commit dad2f62e0a on Sep 19, 2017
  26. codablock referenced this in commit 5d54581235 on Dec 9, 2017
  27. codablock referenced this in commit 723eacf454 on Dec 9, 2017
  28. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-07-03 10:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me