getmemorypool should call CheckWork like getwork instead of ProcessBlock #732

issue TheBlueMatt opened this issue on December 30, 2011

TheBlueMatt commented at 9:09 AM on December 30, 2011: member

In bitcoinrpc.cpp
TheBlueMatt commented at 9:10 AM on December 30, 2011: member

Also, the IsInitialBlockDownload and vNodes.empty() checks should be outside the if, like in getwork
laanwj commented at 1:00 PM on April 29, 2014: member

Closing this: there is no getmemorypool RPC (anymore?)
laanwj closed this on Apr 29, 2014
sipa commented at 1:02 PM on April 29, 2014: member

getmemorypool was renamed to getblocktemplate.
laanwj commented at 1:17 PM on April 29, 2014: member

I had a vague idea that was the case, but I don't understand the issue in that context, either. gbt doesn't call either ProcessBlock or CheckWork. And which if statement? why?
sipa commented at 1:19 PM on April 29, 2014: member

Right, that functionality was split off from getblocktemplate to submitblock.
destenson referenced this in commit e0c4dd0129 on Jun 26, 2016
destenson referenced this in commit 965436fcb5 on Aug 8, 2017
sipa referenced this in commit ef7117193c on May 22, 2020
sipa referenced this in commit 67f232b5d8 on Jun 9, 2020
stackman27 referenced this in commit 78cde6f8c7 on Jun 26, 2020
DrahtBot locked this on Sep 8, 2021

Contributors