make sure IsMine only returns true when we own all keys #733

pull ghost wants to merge 1 commits into bitcoin:master from changing 2 files +5 −2

ghost commented at 7:35 AM on January 2, 2012: none

No description provided.
TheBlueMatt commented at 8:47 PM on January 2, 2012: member

Whats the motivation for this? Also, wont this break a ton of other logic?

ghost commented at 10:19 PM on January 2, 2012: none

it fixes what I perceived to be a bug since the code didn't act as this comment said it should:

    // Only consider transactions "mine" if we own ALL the
    // keys involved. multi-signature transactions that are
    // partially owned (somebody else has a key that can spend
    // them) enable spend-out-from-under-you attacks, especially
    // in shared-wallet situations.

make sure IsMine only returns true when we own all keys 6ec76ca09e
TheBlueMatt commented at 5:39 AM on January 3, 2012: member

Sorry, I saw IsMine and didnt bother to read that it was in MULTISIG...gavin would know better if this is a bug.
gavinandresen merged this on Jan 3, 2012
gavinandresen closed this on Jan 3, 2012
destenson referenced this in commit 38f386ae1c on Jun 26, 2016
ptschip referenced this in commit 706c5ce8c1 on Aug 8, 2017
DrahtBot locked this on Sep 8, 2021

Contributors

ghost

TheBlueMatt