[qt] Windows: Make rpcconsole monospace font larger #7364

1. 
   MarcoFalke commented at 6:30 PM on January 17, 2016: member

   Probably fixes #7017.

   Merges fine into master and 0.12.

2. [qt] Windows: Make rpcconsole monospace font larger fa6a59dd39
3. 
   jonasschnelli commented at 6:55 PM on January 17, 2016: contributor

   utACK for 0.12 (rc2) not sure if we want this for master/0.13 or if we should look for a better/alternative solution.

   Build to test should be ready soon: https://bitcoin.jonasschnelli.ch/pulls/7364/

4. jonasschnelli added the label GUI on Jan 17, 2016
5. jonasschnelli added this to the milestone 0.12.0 on Jan 17, 2016
6. 
   MarcoFalke commented at 7:02 PM on January 17, 2016: member

   Thanks for the binaries.

   Even though this is ugly, I'd say it should be merged into master as well. Lacking a better solution, it doesn't make things worse and backports easier.

7. 
   luke-jr commented at 7:10 PM on January 17, 2016: member

   Why are we not using QFontInfo(fixedFontInfo).pointSize() here?

8. 
   MarcoFalke commented at 7:16 PM on January 17, 2016: member

   @luke-jr dejavu #6864. (tl;dr too large)

9. 
   luke-jr commented at 7:25 PM on January 17, 2016: member

   Seems like QFont() has the same problems? Makes more sense to scale fixedFontInfo than to scale some other font's default size. Besides, we got that Qt5 thing since then?

10. 
    MarcoFalke commented at 7:31 PM on January 17, 2016: member

    Makes more sense to scale fixedFontInfo than to scale some other font's default size

    Previously we had a "default font", so that's the reference. Though, you are welcome to change that.

    Besides, we got that Qt5 thing since then?

    Doesn't change anything for Windows or Linux. Only a different font for OS X.

11. 
    laanwj commented at 9:12 AM on January 18, 2016: member

    Oh no, not more monospace related code changes. When are you guys going to give this up :-)

12. jonasschnelli added the label Windows on Jan 18, 2016
13. 
    jonasschnelli commented at 8:46 AM on January 22, 2016: contributor

    Tested ACK fa6a59dd397e62e850fc57df05cd6d117fbdcd82. This is a quick and stable workaround and we should backport this to 0.12. For 0.13 we need a better solution.

    Current Master (to small on windows): <img width="620" alt="bildschirmfoto 2016-01-22 um 09 39 07" src="https://cloud.githubusercontent.com/assets/178464/12506086/a30392a0-c0ec-11e5-979e-04377b914084.png">

    Current 0.11 version, non pretty, non mono (people are use to this font size): <img width="670" alt="bildschirmfoto 2016-01-22 um 09 41 02" src="https://cloud.githubusercontent.com/assets/178464/12506093/b067969e-c0ec-11e5-90ac-2daf36261565.png">

    This PR: <img width="612" alt="bildschirmfoto 2016-01-22 um 09 38 12" src="https://cloud.githubusercontent.com/assets/178464/12506098/bd7b481c-c0ec-11e5-941a-abb18f8d5f97.png">

14. jonasschnelli added the label Needs backport on Jan 22, 2016
15. jonasschnelli merged this on Jan 22, 2016
16. jonasschnelli closed this on Jan 22, 2016

    ---

17. jonasschnelli referenced this in commit f221fc1887 on Jan 22, 2016
18. laanwj referenced this in commit 7726c487f8 on Jan 22, 2016
19. 
    laanwj commented at 10:23 AM on January 22, 2016: member

    I don't think this solution is acceptable in the longer term. We have to do one of these:

    • Remove the #ifdef, just accept that the font is too big on some OSes (better too big than too small)
    • Revert the console to proportional font as in 0.10.x
20. MarcoFalke deleted the branch on Jan 22, 2016
21. 
    luke-jr commented at 3:18 PM on January 22, 2016: member

    @laanwj http://permalink.gmane.org/gmane.mail.trojita.general/1315

22. laanwj removed the label Needs backport on Feb 4, 2016
23. MarcoFalke locked this on Sep 8, 2021

Milestone
0.12.0