[Qt] rename "amount" to "requested amount" in receive coins table #7383

pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:2016/01/qt_req_amount changing 3 files +4 −8

jonasschnelli commented at 2:01 PM on January 20, 2016: contributor

Addresses #7014 (partial).

Users can be confused by looking at the "amount" column in the receive coins table (history or created addresses) because they expect the amount of "coins received by this address" instead of the "requested amount".

Renaming table header from "amount" to "requested amount".
jonasschnelli added the label GUI on Jan 20, 2016
laanwj commented at 2:17 PM on January 20, 2016: member

utACK (nit: please change the commit and pull request title to "requested amount" too)
jonasschnelli renamed this:
~~[Qt] rename "amount" to "received amount" in receive coins table~~
[Qt] rename "amount" to "requested amount" in receive coins table
on Jan 20, 2016
jonasschnelli force-pushed on Jan 20, 2016
jonasschnelli commented at 2:21 PM on January 20, 2016: contributor

Sorry. Typo. Fixed (reworded commit and PR title to "requested amount").
MarcoFalke commented at 3:30 PM on January 20, 2016: member

utACK 6693cb2

in src/qt/recentrequeststablemodel.cpp:None in 6693cb26a8 outdated

 124 | @@ -125,7 +125,7 @@ void RecentRequestsTableModel::updateAmountColumnTitle()
 125 |  /** Gets title for amount column including current display unit if optionsModel reference available. */
 126 |  QString RecentRequestsTableModel::getAmountTitle()
 127 |  {
 128 | -    QString amountTitle = tr("Amount");
 129 | +    QString amountTitle = tr("Requested Amount");
 130 |      if (this->walletModel->getOptionsModel() != NULL)
 131 |      {
 132 |          amountTitle += " ("+BitcoinUnits::name(this->walletModel->getOptionsModel()->getDisplayUnit()) + ")";

MarcoFalke commented at 3:53 PM on January 20, 2016:

What about

 QString RecentRequestsTableModel::getAmountTitle()
 {
-    QString amountTitle = tr("Amount");
     if (this->walletModel->getOptionsModel() != NULL)
-    {
-        amountTitle += " ("+BitcoinUnits::name(this->walletModel->getOptionsModel()->getDisplayUnit()) + ")";
-    }
-    return amountTitle;
+        return tr("Requested") + " ("+BitcoinUnits::name(this->walletModel->getOptionsModel()->getDisplayUnit()) + ")";
+    else
+        return tr("Requested amount");
 }

in src/qt/receivecoinsdialog.h:None in 6693cb26a8 outdated

  35 | @@ -36,7 +36,7 @@ class ReceiveCoinsDialog : public QDialog
  36 |      enum ColumnWidths {
  37 |          DATE_COLUMN_WIDTH = 130,
  38 |          LABEL_COLUMN_WIDTH = 120,
  39 | -        AMOUNT_MINIMUM_COLUMN_WIDTH = 160,
  40 | +        AMOUNT_MINIMUM_COLUMN_WIDTH = 180,

MarcoFalke commented at 3:53 PM on January 20, 2016:

Needs to be larger for me. (Or use the diff I provided below)

screenshot from 2016-01-20 16-50-46

fanquake commented at 3:56 PM on January 20, 2016: member

utACK
jonasschnelli force-pushed on Jan 20, 2016
jonasschnelli commented at 4:16 PM on January 20, 2016: contributor

Applied @MarcoFalke diff (force push). Thanks. It's a nice solution for a smaller column.
[Qt] rename "amount" to "requested amount" in receive coins table df6e8e17e4
in src/qt/recentrequeststablemodel.cpp:None in 430674ccee outdated
```
 131 | -        amountTitle += " ("+BitcoinUnits::name(this->walletModel->getOptionsModel()->getDisplayUnit()) + ")";
 132 | -    }
 133 | -    return amountTitle;
 134 | +        return tr("Requested") + " ("+BitcoinUnits::name(this->walletModel->getOptionsModel()->getDisplayUnit()) + ")";
 135 | +    else
 136 | +        return tr("Requested amount");
```
laanwj commented at 4:23 PM on January 20, 2016:

I don't think we need a special translation for the case that the model is not set, it is an error case which shouldn't crash but there's no need to make translators work for it (just return empty or something like that).

jonasschnelli commented at 4:30 PM on January 20, 2016:

What do you think about the new solution?
jonasschnelli force-pushed on Jan 20, 2016
jonasschnelli merged this on Jan 21, 2016
jonasschnelli closed this on Jan 21, 2016
jonasschnelli referenced this in commit ae2db67fee on Jan 21, 2016
MarcoFalke referenced this in commit 6309d868d1 on Jan 21, 2016
codablock referenced this in commit 59d5090bbb on Sep 16, 2017
codablock referenced this in commit c5e66c9a6d on Sep 19, 2017
codablock referenced this in commit 212f84809e on Dec 9, 2017
codablock referenced this in commit 43700eef36 on Dec 9, 2017
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#7014 Receive screen: add new column for "received per address"