Add security/export checks to gitian and fix current failures #7424

pull theuni wants to merge 5 commits into bitcoin:master from theuni:binary-checks changing 7 files +34 −7
  1. theuni commented at 4:12 AM on January 27, 2016: member

    Fixes #7420. This was discussed and agreed upon a long time ago, but I never got around to actually doing it. Sorry to do this during the rc stage, @laanwj, but at least it was discovered before final release.

    Thanks very much to @dlogemann for testing the rcs and reporting the issue.

    This fixes glibc back-compat issues with the current toolchain, and adds the checks to gitian so that breakage won't go unnoticed again. With a few more tweaks, it should be safe enough to add to 'make check' so that Travis tests with each build, but not quite yet.

    I've verified that Gitian builds for Linux/Win are successful, OSX should be unchanged.

  2. release: fix parsing of BIND_NOW with older readelf cd27bf51e0
  3. release: add _IO_stdin_used to ignored exports
    For details see: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=634261#109
    475813ba5b
  4. release: add check-symbols and check-security make targets
    These are not added to the default checks because some of them depend on
    release-build configs.
    f3d3eaf78e
  5. release: always link librt for glibc back-compat builds
    glibc absorbed clock_gettime in 2.17. librt (its previous location) is safe to
    link in anyway for back-compat.
    
    Fixes #7420
    a8ce872118
  6. release: add security/symbol checks to gitian a81c87fafc
  7. theuni commented at 4:15 AM on January 27, 2016: member

    Note that I was actually testing these changes cherry-picked into the 0.12 branch. They should move with no conflicts.

  8. jonasschnelli added the label Build system on Jan 27, 2016
  9. jonasschnelli commented at 8:09 AM on January 27, 2016: contributor

    Concept ACK.

  10. laanwj commented at 9:06 AM on January 27, 2016: member

    Yay, thanks utACK

  11. laanwj added this to the milestone 0.12.0 on Jan 27, 2016
  12. laanwj merged this on Jan 27, 2016
  13. laanwj closed this on Jan 27, 2016

  14. laanwj referenced this in commit 42ecea48fd on Jan 27, 2016
  15. laanwj referenced this in commit aa26ee0101 on Jan 27, 2016
  16. laanwj commented at 10:35 AM on January 27, 2016: member

    Backported to 0.12 as aa26ee0. Looks like this forces another RC. I wasn't sure yet whether the hardcoded seed update was enough necessity, but this fixes a critical issue.

  17. zkbot referenced this in commit 4ee9d712b5 on Oct 17, 2016
  18. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-18 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me