Add whitelistforcerelay to control forced relaying. [#7099 redux] #7439

1. 
   gmaxwell commented at 10:53 PM on January 28, 2016: contributor

   Also renames whitelistalwaysrelay.

   Nodes relay all transactions from whitelisted peers, this gets in the way of some useful reasons for whitelisting peers-- for example, bypassing bandwidth limitations.

   The purpose of this forced relaying is for specialized gateway applications where a node is being used as a P2P connection filter and multiplexer, but where you don't want it getting in the way of (re-)broadcast.

   This change makes it configurable with whitelistforcerelay.

2. Add whitelistforcerelay to control forced relaying.

   Also renames whitelistalwaysrelay.
   
   Nodes relay all transactions from whitelisted peers, this
    gets in the way of some useful reasons for whitelisting
    peers-- for example, bypassing bandwidth limitations.
   
   The purpose of this forced relaying is for specialized gateway
    applications where a node is being used as a P2P connection
    filter and multiplexer, but where you don't want it getting
    in the way of (re-)broadcast.
   
   This change makes it configurable with whitelistforcerelay.

   325c725fb6
3. jonasschnelli added the label P2P on Jan 29, 2016
4. 
   laanwj commented at 11:50 AM on January 29, 2016: member

   utACK 325c725

5. laanwj added this to the milestone 0.12.0 on Jan 29, 2016
6. in src/init.cpp:None in 325c725fb6 outdated

    752 | @@ -752,13 +753,19 @@ void InitParameterInteraction()
    753 |  
    754 |      // disable walletbroadcast and whitelistalwaysrelay in blocksonly mode
   

   ---

   ---

   

   MarcoFalke commented at 4:51 PM on January 29, 2016:

   You'd need to make the rename globally; Also, I don't like that this just ignores -whitelistalwaysrelay set in old .conf files.

   ---

   

   laanwj commented at 10:50 AM on January 30, 2016:

   Valid point, although how old can these conf files be, given that whitelistalwaysrelay was introduced in #6993 only two months ago, so isn't in any releases.

   ---

   

   MarcoFalke commented at 11:00 AM on January 30, 2016:

   I guess there are three options:

   • Silently accept both variations
   • Ignore
   • Add it to the blacklist https://github.com/gmaxwell/bitcoin/blob/325c725fb6205e38142914acb9ed1733d8482d46/src/init.cpp#L892-L903
7. 
   MarcoFalke commented at 4:52 PM on January 29, 2016: member

   Concept ACK

8. 
   petertodd commented at 9:32 AM on January 31, 2016: contributor

   utACK 325c725fb6205e38142914acb9ed1733d8482d46

9. 
   laanwj commented at 12:21 PM on February 1, 2016: member

   Travis is failing, but I cannot quite see why.

10. 
    gmaxwell commented at 12:23 PM on February 1, 2016: contributor

    I think it started failing when I added the requested argument rejection. Does a test run with it? git grep yields nothing.

11. Blacklist -whitelistalwaysrelay; replaced by -whitelistrelay. 89d113e02a
12. 
    MarcoFalke commented at 12:38 PM on February 1, 2016: member

    utACK 89d113e. Thanks for sticking with this, I like the confs.

13. laanwj merged this on Feb 1, 2016
14. laanwj closed this on Feb 1, 2016

    ---

15. laanwj referenced this in commit 58a8574400 on Feb 1, 2016
16. laanwj referenced this in commit 86755bc85a on Feb 1, 2016
17. codablock referenced this in commit 8b472035b6 on Sep 16, 2017
18. codablock referenced this in commit 5bc6fe2194 on Sep 19, 2017
19. codablock referenced this in commit bfb98342d6 on Dec 9, 2017
20. codablock referenced this in commit 63268465a6 on Dec 9, 2017
21. codablock referenced this in commit 5f68e06a07 on Dec 11, 2017
22. zkbot referenced this in commit ba4eb241e7 on Mar 31, 2021
23. MarcoFalke locked this on Sep 8, 2021

Contributors

gmaxwelllaanwjMarcoFalkepetertodd

Milestone
0.12.0