Revert fork of JSON-Spirit #751

issue TheBlueMatt opened this issue on January 9, 2012
  1. TheBlueMatt commented at 6:16 PM on January 9, 2012: member

    Currently we use a slight fork of (an outdated) JSON-Spirit (http://www.codeproject.com/KB/recipes/JSON_Spirit.aspx) in our repo. The debian maintainer for Bitcoin asked me a while ago (and I never got around to filing a bug report for it) if it were possible for us to revert back to the original version so that it is possible to use a packaged version. To do this, we need support for forcing numerical output to do fixed-length output of reals (see http://www.codeproject.com/KB/recipes/JSON_Spirit.aspx?fid=448567&tid=3909548 and scroll to the bottom to read a brief thread on the subject, it would be much appreciated if someone could take up that topic and continue with this issue).

  2. luke-jr commented at 6:21 PM on January 9, 2012: member

    As much as I prefer avoiding forking, there's little to no benefit in this case as JSON-Spirit only provides/supports static linking...

  3. TheBlueMatt commented at 6:27 PM on January 9, 2012: member

    Hence why its really not an important issue, its just something that would be nice to do eventually (there isnt a JSON-Spirit debian package right now anyway...)

  4. laanwj commented at 1:52 PM on April 23, 2014: member

    Looks like a json-spriit package in Debian exists now: https://packages.debian.org/zh/source/sid/json-spirit Not that we can use it, as our custom changes to the library are extremely important as long as floats are used for monetary values... After the RPC redesign, if we decide to use strings instead (see also #3759), we can revert to the system package.

  5. laanwj commented at 10:03 AM on September 25, 2014: member

    Looks like we're rather going to move away from JSON-spirit completely. Closing in favor of #4738.

  6. laanwj closed this on Sep 25, 2014

  7. destenson referenced this in commit abbfb0a6c9 on Jun 26, 2016
  8. ptschip referenced this in commit 587d2108c3 on Aug 19, 2017
  9. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 09:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me