Replace boolean allowhighfees with an Array of rejections to ignore (in a backward compatible manner)
This is useful for node operators who wish to manually accept transactions that don’t meet their typical policies, yet don’t necessarily want to override all the policies.
It’s a bit ugly internally - suggestions on improving that are welcome.
280@@ -281,7 +281,22 @@ void PruneAndFlush();
281
282 /** (try to) add transaction to memory pool **/
283 bool AcceptToMemoryPool(CTxMemPool& pool, CValidationState &state, const CTransaction &tx, bool fLimitFree,
fLimitFree, which is only hardcoded to false for the wallet and sendrawtransaction?
Typically people only want to bypass a specific policy, and not others. For example, a miner might want to bypass the fee checks or bypass the ancestor limit on replacements, but not other policies.
Will have a rebase done soon.
@jameshilliard It can’t be added externally… Looking at the first failure reason won’t tell you if it violates other policies as well.
Anyhow, rebase is ready for review, and refactored somewhat so hopefully it’s also easier to review.
BIP22-like
I think the ability to override specific rejection reasons is overkill, and risks creating an interface that is unmaintainable.
A boolean to say “ignore all policy, accept if consensus-valid” would be fine, though.
