[build-aux] Correct AC_PACKAGE_NAME brackets in bitcoin m4 scripts #7559

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:correct-m4-brackets changing 2 files +3 −3

fanquake commented at 1:54 PM on February 19, 2016: member

Closes #7519 @luke-jr can you advise if this was done on purpose or not?
[build-aux] Correct AC_PACKAGE_NAME brackets in m4 scripts 83b0c7ff5e
fanquake closed this on Feb 19, 2016
laanwj commented at 2:29 PM on February 19, 2016: member

Why close?

paveljanik commented at 2:31 PM on February 19, 2016: contributor

Travis failed on all systems:

configure:21110: error: possibly undefined macro: AC_PACKAGE_NAME
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
autoreconf: /usr/bin/autoconf failed with exit status: 1
The command "test -n "$USE_SHELL" && eval '"$USE_SHELL" -c "./autogen.sh"' || ./autogen.sh" exited with 1.

I'd be happy if someone helps me to understand it 8)

fanquake reopened this on Feb 19, 2016
fanquake commented at 2:48 PM on February 19, 2016: member

@laanwj If this is going to be changed I think it needs to be done another way. I'd rather find out if it is correct or not.
luke-jr commented at 3:21 PM on February 19, 2016: member

It's intentionally for _de_quoting.
jonasschnelli added the label Build system on Feb 20, 2016
laanwj commented at 10:44 AM on February 24, 2016: member

So ]VARIABLE[ is intentional syntax. I's unfortunate that searching for such symbols on google is hard, would love a documentation reference for that. But it works so @luke-jr is likely right (and I don't see a need to correct something that is not broken).
laanwj closed this on Feb 24, 2016
fanquake deleted the branch on Feb 24, 2016
paveljanik commented at 10:47 AM on February 24, 2016: contributor

me too 8)
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)