Corrections of 0.12 release notes #7581

pull instagibbs wants to merge 1 commits into bitcoin:master from instagibbs:patch-2 changing 1 files +1 −1

instagibbs commented at 2:54 PM on February 23, 2016: member

No description provided.
Corrections of 0.12 release notes 24a012c9b2

in doc/release-notes/release-notes-0.12.0.md:None in d4d3323b0d outdated

 165 | @@ -166,12 +166,13 @@ creating transactions that would be replaceable under BIP 125.
 166 |  RPC: Random-cookie RPC authentication
 167 |  -------------------------------------
 168 |  
 169 | -When no `-rpcpassword` is specified, the daemon now uses a special 'cookie'
 170 | -file for authentication. This file is generated with random content when the
 171 | +The daemon now uses a special 'cookie' file for authentication.

laanwj commented at 3:00 PM on February 23, 2016:

I'm not sure this is more clear. Cookie authentication is only used when no -rpcpassword is specified, it's not suddenly used in previous setups.

instagibbs commented at 3:10 PM on February 23, 2016:

ok I derped. Someone else had tested this(incorrectly?) on IRC and I remembered wrong. It's rpcauth which is tried after cookie auth.

instagibbs force-pushed on Feb 23, 2016
Michagogo commented at 4:21 PM on February 23, 2016: contributor

This is still inaccurate. Rescans don't work. This is true whether they're manually initiated via the rescan flag or as part of one of those RPCs. I realize the intent is to make it clear that those commands are still possible sans rescan, but it goes too far and now doesn't indicate that a standalone rescan won't work.
jonasschnelli added the label Docs and Output on Feb 24, 2016
jonasschnelli commented at 6:46 AM on February 24, 2016: contributor

IMO the current release notes (without this PR) is okay. Unless we have a rescan-down-to-height feature (which we don't have in 0.12), rescans don't work with pruning (current rescans always start at genesis). Tend to NACK.
laanwj commented at 10:21 AM on February 24, 2016: member

I don't think this change is correct either. -rescan doesn't work with pruning, period. RPC calls such as import will work without rescan, though.

I'm sure that could be worded better, though.

But there's a limit on how much time we should spend on polishing release notes on a release that's already "history". Let's try to have the next releases's release notes ready in time for the next release :-)
laanwj closed this on Feb 24, 2016
instagibbs commented at 12:06 PM on February 24, 2016: member

Agreed On Feb 24, 2016 5:22 AM, "Wladimir J. van der Laan" < notifications@github.com> wrote:

Closed #7581 #7581.

— Reply to this email directly or view it on GitHub #7581#event-563326858.
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels