Improving wording related to Boost library requirements #7589

pull jonathancross wants to merge 5 commits into bitcoin:master from jonathancross:patch-2 changing 1 files +7 −4

jonathancross commented at 12:15 PM on February 24, 2016: contributor

Documentation was unclear in this section and could be interpreted to mean that boost was not a hard requirement for older Ubuntu versions. Related: #7587

Improving wording related to required Boost library requirement

Documentation was unclear in this section and could be interpreted to mean that boost was not a hard requirement for older Ubuntu versions.
Related: https://github.com/bitcoin/bitcoin/issues/7587

417e64bc01

jonathancross renamed this:
~~Improving wording related to required Boost library requirement~~
Improving wording related to Boost library requirements
on Feb 24, 2016

in doc/build-unix.md:None in 417e64bc01 outdated

  74 | +1. On at least Ubuntu 14.04+ and Debian 7+ there are generic names for the
  75 |  individual boost development packages, so the following can be used to only
  76 |  install necessary parts of boost:
  77 |  
  78 | -    sudo apt-get install libboost-system-dev libboost-filesystem-dev libboost-chrono-dev libboost-program-options-dev libboost-test-dev libboost-thread-dev
  79 | +    `sudo apt-get install libboost-system-dev libboost-filesystem-dev libboost-chrono-dev libboost-program-options-dev libboost-test-dev libboost-thread-dev`

jonasschnelli commented at 12:20 PM on February 24, 2016:

nit: IMO if you use a 4-spaces-indent that's equivalent to `

laanwj commented at 12:43 PM on February 24, 2016:

Yes, either do

install necessary parts of boost:
```bash
<commands go here>
```

Or indent four spaces:

install necessary parts of boost:

    <commands go here>

Both is not valid markdown.

jonathancross commented at 12:54 PM on February 24, 2016:

Thank you both. The Ordered list (numbers 1 and 2) formatting cause markdown to ignore the 4-space "code" indentation markup. I did some experimentation and now see that I need to indent 8 spaces to bring back the code formatting when in a list.

Now fixed.

jonasschnelli commented at 12:20 PM on February 24, 2016: contributor

ACK 417e64bc0176db5d17d8ed0f03fc64154cbd00b8
jonasschnelli added the label Docs and Output on Feb 24, 2016
Merge pull request #1 from bitcoin/master
Merging in latest changes.
3306e5859e
Replacing backticks with additional 4-space code indentation 2cdcc6454f

Improving wording related to required Boost library requirement

Documentation was unclear in this section and could be interpreted to mean that boost was not a hard requirement for older Ubuntu versions.
Related: https://github.com/bitcoin/bitcoin/issues/7587

This squashed commit replaces backticks with additional 4-space code indentation.

4adf0bf43a

Merge branch 'patch-2' of github.com:jonathancross/bitcoin into patch-2 557fd15a70
jonathancross commented at 2:39 PM on February 24, 2016: contributor

I went ahead and created a new clean pull request #7590 with a single commit and the formatting changes requested.
jonathancross closed this on Feb 24, 2016
jonathancross deleted the branch on Feb 27, 2016
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#7587 0.12.0 Precise PPA builds failing: error: Could not find a version of the boost_program_options library!#7590 Improving wording related to Boost library requirements [updated]